andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add unit test not on /dev/shm as part of the pre-commit tests

Browse Source 
Summary: RocksDB behavior is slightly different between data on tmpfs and normal file systems. Add a test case to run RocksDB on normal file system.

Test Plan: See the tests launched by Phabricator

Reviewers: kradhakrishnan, IslamAbdelRahman, gunnarku

Reviewed By: gunnarku

Subscribers: leveldb, andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D60963
This commit is contained in:
sdong 2016-07-21 12:53:02 -07:00
parent b9a97181aa
commit b50632920d
3 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -1375,7 +1375,7 @@ jdb_bench:
commit_prereq: build_tools/rocksdb-lego-determinator \ commit_prereq: build_tools/rocksdb-lego-determinator \
build_tools/precommit_checker.py build_tools/precommit_checker.py
J=$(J) build_tools/precommit_checker.py unit unit_481 clang_unit release release_481 clang_release tsan asan ubsan lite J=$(J) build_tools/precommit_checker.py unit unit_481 clang_unit release release_481 clang_release tsan asan ubsan lite unit_non_shm
$(MAKE) clean && $(MAKE) jclean && $(MAKE) rocksdbjava; $(MAKE) clean && $(MAKE) jclean && $(MAKE) rocksdbjava;
xfunc: xfunc:

4
arcanist_util/config/RocksDBCommonHelper.php
View File

@ -223,8 +223,8 @@ function getSandcastleConfig() {
} else { } else {
// Manually list of tests we want to run in Sandcastle. // Manually list of tests we want to run in Sandcastle.
$tests = array( $tests = array(
"unit", "unit_481", "clang_unit", "tsan", "asan", "lite_test", "unit", "unit_non_shm", "unit_481", "clang_unit", "tsan", "asan",
"valgrind", "release", "release_481", "clang_release" "lite_test", "valgrind", "release", "release_481", "clang_release"
); );
} }

23
build_tools/rocksdb-lego-determinator
View File

@ -146,6 +146,26 @@ UNIT_TEST_COMMANDS="[
} }
]" ]"
#
# RocksDB unit test not under /dev/shm
#
UNIT_TEST_NON_SHM_COMMANDS="[
{
'name':'Rocksdb Unit Test',
'oncall':'$ONCALL',
'steps': [
$CLEANUP_ENV,
{
'name':'Build and test RocksDB debug version',
'shell':'$DEBUG make J=1 check',
'user':'root',
$PARSER
},
],
$REPORT
}
]"
# #
# RocksDB release build and unit tests # RocksDB release build and unit tests
# #
@ -724,6 +744,9 @@ case $1 in
unit) unit)
echo $UNIT_TEST_COMMANDS echo $UNIT_TEST_COMMANDS
;; ;;
unit_non_shm)
echo $UNIT_TEST_NON_SHM_COMMANDS
;;
release) release)
echo $RELEASE_BUILD_COMMANDS echo $RELEASE_BUILD_COMMANDS
;; ;;