From ba8aa8fdc8b7081a17df9e44d75eab84e8bd43f3 Mon Sep 17 00:00:00 2001 From: Fosco Marotto Date: Thu, 1 Feb 2018 13:54:50 -0800 Subject: [PATCH] Upgrade Appveyor to VS2017 Summary: Per some discussions, this will switch our Appveyor testing to use Visual Studio 2017. Closes https://github.com/facebook/rocksdb/pull/3445 Differential Revision: D6874918 Pulled By: gfosco fbshipit-source-id: c5a0032ca9f37f0d3baeae35c59d850d528c3176 --- appveyor.yml | 4 ++-- db/external_sst_file_test.cc | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 65a521370..576042cdf 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,9 +1,9 @@ version: 1.0.{build} -image: Visual Studio 2015 +image: Visual Studio 2017 before_build: - md %APPVEYOR_BUILD_FOLDER%\build - cd %APPVEYOR_BUILD_FOLDER%\build -- cmake -G "Visual Studio 14 Win64" -DOPTDBG=1 -DWITH_XPRESS=1 -DPORTABLE=1 .. +- cmake -G "Visual Studio 15 Win64" -DOPTDBG=1 -DWITH_XPRESS=1 -DPORTABLE=1 .. - cd .. build: project: build\rocksdb.sln diff --git a/db/external_sst_file_test.cc b/db/external_sst_file_test.cc index 89e949ff0..8f7c86839 100644 --- a/db/external_sst_file_test.cc +++ b/db/external_sst_file_test.cc @@ -388,9 +388,10 @@ class SstFileWriterCollector : public TablePropertiesCollector { const char* Name() const override { return name_.c_str(); } Status Finish(UserCollectedProperties* properties) override { + std::string count = std::to_string(count_); *properties = UserCollectedProperties{ {prefix_ + "_SstFileWriterCollector", "YES"}, - {prefix_ + "_Count", std::to_string(count_)}, + {prefix_ + "_Count", count}, }; return Status::OK(); }