andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix InternalStats::DumpCFStats (#7666)

Browse Source 
Summary:
https://github.com/facebook/rocksdb/pull/7461 accidentally broke
`InternalStats::DumpCFStats` by making `DumpCFFileHistogram` overwrite
the output of `DumpCFStatsNoFileHistogram` instead of appending to it,
resulting in only the file histogram related information getting logged.
The patch fixes this by reverting to appending in `DumpCFFileHistogram`.

Fixes https://github.com/facebook/rocksdb/issues/7664 .

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7666

Test Plan: Ran `make check` and checked the info log of `db_bench`.

Reviewed By: riversand963

Differential Revision: D24929051

Pulled By: ltamasi

fbshipit-source-id: 636a3d5ebb5ce23de4f3fe4f03ad3f16cb2858f8
This commit is contained in:
Levi Tamasi 2020-11-12 17:31:28 -08:00 committed by Facebook GitHub Bot
parent cf9d8e45c0
commit bb69b4ce7f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
db/internal_stats.cc
View File

@ -1406,7 +1406,7 @@ void InternalStats::DumpCFFileHistogram(std::string* value) {
<< blob_file_read_latency_.ToString() << '\n';
}
*value = oss.str();
value->append(oss.str());
}
#else