andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Refine the statistics

Browse Source
This commit is contained in:
kailiu 2013-12-06 16:51:35 -08:00
parent 551e9428ce
commit c7707f24c2
2 changed files with 45 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
include/rocksdb/statistics.h
View File

@ -7,7 +7,6 @@
#define STORAGE_ROCKSDB_INCLUDE_STATISTICS_H_ #define STORAGE_ROCKSDB_INCLUDE_STATISTICS_H_
#include <atomic> #include <atomic>
#include <cassert>
#include <cstddef> #include <cstddef>
#include <cstdint> #include <cstdint>
#include <string> #include <string>
@ -18,10 +17,8 @@ namespace rocksdb {
/** /**
* Keep adding ticker's here. * Keep adding ticker's here.
* Any ticker should have a value less than TICKER_ENUM_MAX. * 1. Any ticker should be added before TICKER_ENUM_MAX.
* Add a new ticker by assigning it the current value of TICKER_ENUM_MAX * 2. Add a readable string in TickersNameMap below for the newly added ticker.
* Add a string representation in TickersNameMap below.
* And incrementing TICKER_ENUM_MAX.
*/ */
enum Tickers { enum Tickers {
// total block cache misses // total block cache misses
@ -159,7 +156,7 @@ const std::vector<std::pair<Tickers, std::string>> TickersNameMap = {
{ NUMBER_OF_RESEEKS_IN_ITERATION, "rocksdb.number.reseeks.iteration" }, { NUMBER_OF_RESEEKS_IN_ITERATION, "rocksdb.number.reseeks.iteration" },
{ GET_UPDATES_SINCE_CALLS, "rocksdb.getupdatessince.calls" }, { GET_UPDATES_SINCE_CALLS, "rocksdb.getupdatessince.calls" },
{ BLOCK_CACHE_COMPRESSED_MISS, "rocksdb.block.cachecompressed.miss" }, { BLOCK_CACHE_COMPRESSED_MISS, "rocksdb.block.cachecompressed.miss" },
{ BLOCK_CACHE_COMPRESSED_HIT, "rocksdb.block.cachecompressed.hit" } { BLOCK_CACHE_COMPRESSED_HIT, "rocksdb.block.cachecompressed.hit" },
}; };
/** /**
@ -254,7 +251,7 @@ class Ticker {
count_ = count; count_ = count;
} }
inline void recordTick(int count = 1) { inline void recordTick(int64_t count = 1) {
count_ += count; count_ += count;
} }
@ -269,13 +266,12 @@ class Ticker {
// Analyze the performance of a db // Analyze the performance of a db
class Statistics { class Statistics {
public: public:
virtual long getTickerCount(Tickers tickerType) = 0; virtual long getTickerCount(Tickers tickerType) = 0;
virtual void recordTick(Tickers tickerType, uint64_t count = 0) = 0; virtual void recordTick(Tickers tickerType, uint64_t count = 0) = 0;
virtual void setTickerCount(Tickers tickerType, uint64_t count) = 0; virtual void setTickerCount(Tickers tickerType, uint64_t count) = 0;
virtual void measureTime(Histograms histogramType, uint64_t time) = 0; virtual void measureTime(Histograms histogramType, uint64_t time) = 0;
virtual void histogramData(Histograms type, HistogramData * const data) = 0; virtual void histogramData(Histograms type, HistogramData* const data) = 0;
// String representation of the statistic object. // String representation of the statistic object.
std::string ToString(); std::string ToString();
}; };

2
util/statistics_imp.h
View File

@ -11,7 +11,7 @@ namespace rocksdb {
// Utility functions // Utility functions
inline void RecordTick(Statistics* statistics, inline void RecordTick(Statistics* statistics,
Tickers ticker, Tickers ticker,
uint64_t count = 1) { int64_t count = 1) {
assert(HistogramsNameMap.size() == HISTOGRAM_ENUM_MAX); assert(HistogramsNameMap.size() == HISTOGRAM_ENUM_MAX);
assert(TickersNameMap.size() == TICKER_ENUM_MAX); assert(TickersNameMap.size() == TICKER_ENUM_MAX);
if (statistics) { if (statistics) {