andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix integer overflow in TraceOptions (#9157)

Browse Source 
Summary:
Hello from a happy user of rocksdb java :-)

Default constructor of TraceOptions is supposed to initialize size to 64GB but the expression contains an integer overflow.

Simple test case with JShell:
```
jshell> 64 * 1024 * 1024 * 1024
$1 ==> 0

jshell> 64L * 1024 * 1024 * 1024
$2 ==> 68719476736
```

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9157

Reviewed By: pdillinger, zhichao-cao

Differential Revision: D32369273

Pulled By: mrambacher

fbshipit-source-id: 6a0c95fff7a91f27ff15d65b662c6b101756b450
This commit is contained in:
Davide Angelocola 2021-11-17 08:40:38 -08:00 committed by Facebook GitHub Bot
parent 2225f063d4
commit c9539ede76
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
java/src/main/java/org/rocksdb/TraceOptions.java
View File

@ -13,7 +13,7 @@ public class TraceOptions {
private final long maxTraceFileSize;
public TraceOptions() {
this.maxTraceFileSize = 64 * 1024 * 1024 * 1024; // 64 GB
this.maxTraceFileSize = 64L * 1024 * 1024 * 1024; // 64 GB
}
public TraceOptions(final long maxTraceFileSize) {
@ -21,8 +21,8 @@ public class TraceOptions {
}
/**
* To avoid the trace file size grows large than the storage space,
* user can set the max trace file size in Bytes. Default is 64GB
* To avoid the trace file size grows larger than the storage space,
* user can set the max trace file size in Bytes. Default is 64 GB.
*
* @return the max trace size
*/