andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add check for using namespace (#9383)

Browse Source 
Summary:
As title.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9383

Test Plan:
manually add `using namespace` to a file, and run `make check-sources`.
Then, remove `using namespace`, and run `make check-sources`

Reviewed By: ajkr

Differential Revision: D33551706

Pulled By: riversand963

fbshipit-source-id: 1bb8304f38434da7de0656882e62e77673155725
This commit is contained in:
Yanqin Jin 2022-01-12 13:26:17 -08:00 committed by Facebook GitHub Bot
parent 5f2b661f54
commit d247230aec
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
build_tools/check-sources.sh
View File

@ -23,6 +23,14 @@ if [ "$?" != "1" ]; then
BAD=1 BAD=1
fi fi
git grep 'using namespace' -- ':!build_tools' ':!docs' \
':!third-party/folly/folly/lang/Align.h' \
':!third-party/gtest-1.8.1/fused-src/gtest/gtest.h'
if [ "$?" != "1" ]; then
echo '^^^^ Do not use "using namespace"'
BAD=1
fi
if [ "$BAD" ]; then if [ "$BAD" ]; then
exit 1 exit 1
fi fi