andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a clang analyze warning (#5398)

Browse Source 
Summary:
Clang analyzer is reporting a false positive warning thinking `type` is uninitialized. The variable is initialized by `ParseFileName` by reference so assigning a default value to keep clang happy.
Current failure:
```
file/filename.cc:435:15: warning: The left operand of '==' is a garbage value
        (type == kInfoLogFile)) {
         ~~~~ ^
1 warning generated.
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5398

Differential Revision: D15588421

Pulled By: miasantreble

fbshipit-source-id: fb121c270300f3a659e68bc7f6674ff4ddf2df9a
This commit is contained in:
Zhongyi Xie 2019-05-31 16:59:00 -07:00 committed by Facebook Github Bot
parent cae22c53fb
commit d7d8605f56
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
file/filename.cc
View File

@ -413,7 +413,7 @@ Status GetInfoLogFiles(Env* env, const std::string& db_log_dir,
assert(parent_dir != nullptr);
assert(info_log_list != nullptr);
uint64_t number = 0;
FileType type;
FileType type = kLogFile;
if (!db_log_dir.empty()) {
*parent_dir = db_log_dir;