From d9bfb35d31715f6e37c08e9381e9d5ac73bf316a Mon Sep 17 00:00:00 2001 From: Fosco Marotto Date: Fri, 30 Mar 2018 14:23:55 -0700 Subject: [PATCH] Update buckifier and TARGETS Summary: Some flags used via make were not applied in the buckifier/targets file, causing some failures to be missed by testing infra ( ie the one fixed by #3434 ) Closes https://github.com/facebook/rocksdb/pull/3452 Differential Revision: D7457419 Pulled By: gfosco fbshipit-source-id: e4aed2915ca3038c1485bbdeebedfc33d5704a49 --- TARGETS | 4 ++++ buckifier/targets_cfg.py | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/TARGETS b/TARGETS index fd06856a4..356dc5cae 100644 --- a/TARGETS +++ b/TARGETS @@ -25,6 +25,10 @@ rocksdb_compiler_flags = [ "-DTBB", # Needed to compile in fbcode "-Wno-expansion-to-defined", + # Added missing flags from output of build_detect_platform + "-DROCKSDB_PTHREAD_ADAPTIVE_MUTEX", + "-DROCKSDB_BACKTRACE", + "-Wshorten-64-to-32", ] rocksdb_external_deps = [ diff --git a/buckifier/targets_cfg.py b/buckifier/targets_cfg.py index 44ef4fd5e..006f653a2 100644 --- a/buckifier/targets_cfg.py +++ b/buckifier/targets_cfg.py @@ -29,6 +29,10 @@ rocksdb_compiler_flags = [ "-DTBB", # Needed to compile in fbcode "-Wno-expansion-to-defined", + # Added missing flags from output of build_detect_platform + "-DROCKSDB_PTHREAD_ADAPTIVE_MUTEX", + "-DROCKSDB_BACKTRACE", + "-Wshorten-64-to-32", ] rocksdb_external_deps = [