andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Declare snapshot refresh incompatible with delete range (#5625)

Browse Source 
Summary:
The ::snap_refresh_nanos option is incompatible with DeleteRange feature. Currently the code relies on range_del_agg.IsEmpty() to disable it if there are range delete tombstones. However ::IsEmpty does not guarantee that there is no RangeDelete tombstones in the SST files. The patch declares the two features incompatible in inline comments until we later figure how to properly detect the presence of RangeDelete tombstones in compaction inputs.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5625

Differential Revision: D16468218

Pulled By: maysamyabandeh

fbshipit-source-id: bd7beca278bc7e1db75e7ee4522d05a3a6ca86f4
This commit is contained in:
Maysam Yabandeh 2019-07-24 15:17:55 -07:00 committed by Facebook Github Bot
parent 7260347fd1
commit d9dc6b4637
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/rocksdb/options.h
View File

@ -275,6 +275,8 @@ struct ColumnFamilyOptions : public AdvancedColumnFamilyOptions {
// this option helps reducing the cpu usage of long-running compactions. The // this option helps reducing the cpu usage of long-running compactions. The
// feature is disabled when max_subcompactions is greater than one. // feature is disabled when max_subcompactions is greater than one.
// //
// NOTE: This feautre is currently incompatible with RangeDeletes.
//
// Default: 0 // Default: 0
// //
// Dynamically changeable through SetOptions() API // Dynamically changeable through SetOptions() API