andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Move the comment

Browse Source 
Summary: Moving the comment per @haobo suggestion.

Test Plan: No

Reviewers: haobo

Reviewed By: haobo

CC: leveldb, haobo

Differential Revision: https://reviews.facebook.net/D14019
This commit is contained in:
Igor Canadi 2013-11-12 10:07:55 -08:00
parent 4abd219cfc
commit dad425562f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
db/db_impl.cc
View File

@ -1631,10 +1631,10 @@ void DBImpl::BackgroundCallFlush() {
} }
} }
// delete unnecessary files if any, this is done outside the mutex
// If !s.ok(), this means that Flush failed. In that case, we want // If !s.ok(), this means that Flush failed. In that case, we want
// to delete all obsolete files and we force FindObsoleteFiles() // to delete all obsolete files and we force FindObsoleteFiles()
FindObsoleteFiles(deletion_state, !s.ok()); FindObsoleteFiles(deletion_state, !s.ok());
// delete unnecessary files if any, this is done outside the mutex
if (deletion_state.HaveSomethingToDelete()) { if (deletion_state.HaveSomethingToDelete()) {
mutex_.Unlock(); mutex_.Unlock();
PurgeObsoleteFiles(deletion_state); PurgeObsoleteFiles(deletion_state);
@ -1680,12 +1680,12 @@ void DBImpl::BackgroundCallCompaction() {
} }
} }
// delete unnecessary files if any, this is done outside the mutex
// If !s.ok(), this means that Compaction failed. In that case, we want // If !s.ok(), this means that Compaction failed. In that case, we want
// to delete all obsolete files we might have created and we force // to delete all obsolete files we might have created and we force
// FindObsoleteFiles(). This is because deletion_state does not catch // FindObsoleteFiles(). This is because deletion_state does not catch
// all created files if compaction failed. // all created files if compaction failed.
FindObsoleteFiles(deletion_state, !s.ok()); FindObsoleteFiles(deletion_state, !s.ok());
// delete unnecessary files if any, this is done outside the mutex
if (deletion_state.HaveSomethingToDelete()) { if (deletion_state.HaveSomethingToDelete()) {
mutex_.Unlock(); mutex_.Unlock();
PurgeObsoleteFiles(deletion_state); PurgeObsoleteFiles(deletion_state);