From dbffb828faf95062a25f7fb2e9964fa0fc207b81 Mon Sep 17 00:00:00 2001 From: Yueh-Hsuan Chiang Date: Wed, 17 Feb 2016 23:32:14 -0800 Subject: [PATCH] Remove the SyncPoint usage in the destructor of PosixEnv Summary: Remove the SyncPoint usage in the destructor of PosixEnv as none of any active tests is using it. SyncPoint is a test-only utility class, and it's a static varible. As a result, using SyncPoint in the destructor of PosixEnv will make default Env depends on SyncPoint. Removing such dependency could solve the problem crash issue only reproducable in Mac environment. Test Plan: OPT=-DTRAVIS V=1 make -j4 check on Mac environment Reviewers: sdong, anthony Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D54333 --- util/env_posix.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/util/env_posix.cc b/util/env_posix.cc index 5db57c8de..9d549b44d 100644 --- a/util/env_posix.cc +++ b/util/env_posix.cc @@ -131,7 +131,6 @@ class PosixEnv : public Env { // All threads must be joined before the deletion of // thread_status_updater_. delete thread_status_updater_; - TEST_SYNC_POINT("PosixEnv::~PosixEnv():End"); } void SetFD_CLOEXEC(int fd, const EnvOptions* options) {