andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Print out compression type of new SST files in logging

Browse Source 
Summary: Closes https://github.com/facebook/rocksdb/pull/3264

Differential Revision: D6552768

Pulled By: siying

fbshipit-source-id: 6303110aff22f341d5cff41f8d2d4f138a53652d
This commit is contained in:
Siying Dong 2017-12-14 10:18:01 -08:00 committed by Facebook Github Bot
parent 6b77c07379
commit def6a00740
2 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
db/compaction_job.cc
View File

@ -625,7 +625,8 @@ Status CompactionJob::Install(const MutableCFOptions& mutable_cf_options) {
"[%s] compacted to: %s, MB/sec: %.1f rd, %.1f wr, level %d, " "[%s] compacted to: %s, MB/sec: %.1f rd, %.1f wr, level %d, "
"files in(%d, %d) out(%d) " "files in(%d, %d) out(%d) "
"MB in(%.1f, %.1f) out(%.1f), read-write-amplify(%.1f) " "MB in(%.1f, %.1f) out(%.1f), read-write-amplify(%.1f) "
"write-amplify(%.1f) %s, records in: %d, records dropped: %d\n", "write-amplify(%.1f) %s, records in: %d, records dropped: %d "
"output_compression: %s\n",
cfd->GetName().c_str(), vstorage->LevelSummary(&tmp), bytes_read_per_sec, cfd->GetName().c_str(), vstorage->LevelSummary(&tmp), bytes_read_per_sec,
bytes_written_per_sec, compact_->compaction->output_level(), bytes_written_per_sec, compact_->compaction->output_level(),
stats.num_input_files_in_non_output_levels, stats.num_input_files_in_non_output_levels,
@ -634,20 +635,23 @@ Status CompactionJob::Install(const MutableCFOptions& mutable_cf_options) {
stats.bytes_read_output_level / 1048576.0, stats.bytes_read_output_level / 1048576.0,
stats.bytes_written / 1048576.0, read_write_amp, write_amp, stats.bytes_written / 1048576.0, read_write_amp, write_amp,
status.ToString().c_str(), stats.num_input_records, status.ToString().c_str(), stats.num_input_records,
stats.num_dropped_records); stats.num_dropped_records,
CompressionTypeToString(compact_->compaction->output_compression())
.c_str());
UpdateCompactionJobStats(stats); UpdateCompactionJobStats(stats);
auto stream = event_logger_->LogToBuffer(log_buffer_); auto stream = event_logger_->LogToBuffer(log_buffer_);
stream << "job" << job_id_ stream << "job" << job_id_ << "event"
<< "event" << "compaction_finished" << "compaction_finished"
<< "compaction_time_micros" << compaction_stats_.micros << "compaction_time_micros" << compaction_stats_.micros
<< "output_level" << compact_->compaction->output_level() << "output_level" << compact_->compaction->output_level()
<< "num_output_files" << compact_->NumOutputFiles() << "num_output_files" << compact_->NumOutputFiles()
<< "total_output_size" << compact_->total_bytes << "total_output_size" << compact_->total_bytes << "num_input_records"
<< "num_input_records" << compact_->num_input_records << compact_->num_input_records << "num_output_records"
<< "num_output_records" << compact_->num_output_records << compact_->num_output_records << "num_subcompactions"
<< "num_subcompactions" << compact_->sub_compact_states.size(); << compact_->sub_compact_states.size() << "output_compression"
<< CompressionTypeToString(compact_->compaction->output_compression());
if (compaction_job_stats_ != nullptr) { if (compaction_job_stats_ != nullptr) {
stream << "num_single_delete_mismatches" stream << "num_single_delete_mismatches"

2
db/flush_job.cc
View File

@ -209,6 +209,8 @@ Status FlushJob::Run(FileMetaData* file_meta) {
auto stream = event_logger_->LogToBuffer(log_buffer_); auto stream = event_logger_->LogToBuffer(log_buffer_);
stream << "job" << job_context_->job_id << "event" stream << "job" << job_context_->job_id << "event"
<< "flush_finished"; << "flush_finished";
stream << "output_compression"
<< CompressionTypeToString(output_compression_);
stream << "lsm_state"; stream << "lsm_state";
stream.StartArray(); stream.StartArray();
auto vstorage = cfd_->current()->storage_info(); auto vstorage = cfd_->current()->storage_info();