From df7abb4e8de0cac06107fbb5f9a909c0bbc9f08b Mon Sep 17 00:00:00 2001 From: fyrz Date: Fri, 31 Oct 2014 00:04:16 +0100 Subject: [PATCH] [RocksJava] Integrated code review comments - Added TODO comments for disabled methods --- java/rocksjni/options.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/java/rocksjni/options.cc b/java/rocksjni/options.cc index 6cde26327..0f4c19232 100644 --- a/java/rocksjni/options.cc +++ b/java/rocksjni/options.cc @@ -1737,8 +1737,9 @@ void Java_org_rocksdb_Options_prepareForBulkLoad( */ void Java_org_rocksdb_ColumnFamilyOptions_newColumnFamilyOptions( JNIEnv* env, jobject jobj) { - //rocksdb::ColumnFamilyOptions* op = new rocksdb::ColumnFamilyOptions(); - //rocksdb::ColumnFamilyOptionsJni::setHandle(env, jobj, op); + // TODO(fyrz) needs to be enabled back when ColumnFamilyOptions are available + // rocksdb::ColumnFamilyOptions* op = new rocksdb::ColumnFamilyOptions(); + // rocksdb::ColumnFamilyOptionsJni::setHandle(env, jobj, op); } /* @@ -2712,8 +2713,9 @@ void Java_org_rocksdb_ColumnFamilyOptions_setMinPartialMergeOperands( */ void Java_org_rocksdb_DBOptions_newDBOptions(JNIEnv* env, jobject jobj) { - //rocksdb::DBOptions* dbop = new rocksdb::DBOptions(); - //rocksdb::DBOptionsJni::setHandle(env, jobj, dbop); + // TODO(fyrz) needs to be enabled back when DBOptions are available + // rocksdb::DBOptions* dbop = new rocksdb::DBOptions(); + // rocksdb::DBOptionsJni::setHandle(env, jobj, dbop); } /*