andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

db_stress should not keep manifest files under checkpoint directory (#6233)

Browse Source 
Summary:
Recently db_stress starts to use a special Env that keeps all manifest files. This should not apply to checkpoint directory and causes test failure like this:

Verification failed: Checkpoint gave inconsistent state. Status is IO error: While mkdir: /dev/shm/rocksdb/rocksdb_crashtest_whitebox/.checkpoint27.tmp: File exists
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6233

Test Plan: Run crash_test with high chance of checkpoint and make sure it doesn't reproduce.

Differential Revision: D19207250

fbshipit-source-id: 12a931379e2e0572bb84aa658b6d03770c8551d4
This commit is contained in:
sdong 2019-12-20 22:08:44 -08:00 committed by Facebook Github Bot
parent 9d36c066c6
commit e0f9d11a05
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
db_stress_tool/db_stress_env_wrapper.h
View File

@ -20,8 +20,10 @@ class DbStressEnvWrapper : public EnvWrapper {
// We determine whether it is a manifest file by searching a strong, // We determine whether it is a manifest file by searching a strong,
// so that there will be false positive if the directory path contains the // so that there will be false positive if the directory path contains the
// keyword but it is unlikely. // keyword but it is unlikely.
// Checkpoint directory needs to be exempted.
if (!if_preserve_all_manifests || if (!if_preserve_all_manifests ||
f.find("MANIFEST-") == std::string::npos) { f.find("MANIFEST-") == std::string::npos ||
f.find("checkpoint") != std::string::npos) {
return target()->DeleteFile(f); return target()->DeleteFile(f);
} }
return Status::OK(); return Status::OK();