andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix option settable tests

Browse Source 
Summary: In option settable tests, bytes for pointers are not all skipped, so that they may be the same as the special character and cause false positive.

Test Plan: Run the test. Manually verify the issue is not there any more.

Reviewers: IslamAbdelRahman, andrewkr

Reviewed By: IslamAbdelRahman

Subscribers: kradhakrishnan, yiwu, yhchiang, leveldb, andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D56553
This commit is contained in:
sdong 2016-04-11 14:57:27 -07:00 committed by Islam AbdelRahman
parent e189801f76
commit e5d21bfbf1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/options_settable_test.cc
View File

@ -75,8 +75,8 @@ int NumUnsetBytes(char* start_ptr, size_t total_size,
if (*ptr == kSpecialChar) { if (*ptr == kSpecialChar) {
total_unset_bytes_base++; total_unset_bytes_base++;
} }
offset = pair.first + pair.second;
} }
offset = pair.first + pair.second;
} }
for (char* ptr = start_ptr + offset; ptr < start_ptr + total_size; ptr++) { for (char* ptr = start_ptr + offset; ptr < start_ptr + total_size; ptr++) {
if (*ptr == kSpecialChar) { if (*ptr == kSpecialChar) {