From e8b841eb47e98d1721185c35a46441e661cf0d22 Mon Sep 17 00:00:00 2001 From: Andrew Kryczka Date: Thu, 24 Jun 2021 21:04:05 -0700 Subject: [PATCH] add missing fields to `GetLiveFilesMetaData()` (#8460) Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/8460 Reviewed By: jay-zhuang Differential Revision: D29381865 Pulled By: ajkr fbshipit-source-id: 47ba54c25f3cc039d72ea32e1df20875795683b3 --- HISTORY.md | 4 ++++ db/version_set.cc | 3 +++ 2 files changed, 7 insertions(+) diff --git a/HISTORY.md b/HISTORY.md index 6463f5e04..0fd3b470e 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -1,4 +1,8 @@ # Rocksdb Change Log +## Unreleased +### Bug Fixes +* `GetLiveFilesMetaData()` now populates the `temperature`, `oldest_ancester_time`, and `file_creation_time` fields of its `LiveFileMetaData` results when the information is available. Previously these fields always contained zero indicating unknown. + ## 6.22.0 (2021-06-18) ### Behavior Changes * Added two additional tickers, MEMTABLE_PAYLOAD_BYTES_AT_FLUSH and MEMTABLE_GARBAGE_BYTES_AT_FLUSH. These stats can be used to estimate the ratio of "garbage" (outdated) bytes in the memtable that are discarded at flush time. diff --git a/db/version_set.cc b/db/version_set.cc index 44e7462c8..5d5655529 100644 --- a/db/version_set.cc +++ b/db/version_set.cc @@ -5590,6 +5590,9 @@ void VersionSet::GetLiveFilesMetaData(std::vector* metadata) { filemetadata.oldest_blob_file_number = file->oldest_blob_file_number; filemetadata.file_checksum = file->file_checksum; filemetadata.file_checksum_func_name = file->file_checksum_func_name; + filemetadata.temperature = file->temperature; + filemetadata.oldest_ancester_time = file->TryGetOldestAncesterTime(); + filemetadata.file_creation_time = file->TryGetFileCreationTime(); metadata->push_back(filemetadata); } }