From e914b6490d1e53d851f59446468e6f596fa52f6d Mon Sep 17 00:00:00 2001 From: Igor Canadi Date: Wed, 18 Dec 2013 13:37:06 -0800 Subject: [PATCH] Reorder tests Summary: db_test should be the first to execute because it finds the most bugs. Also, when third parties report issues, we don't want ldb error message, we prefer to have db_test error message. For example, see thread: https://github.com/facebook/rocksdb/issues/25 Test Plan: make check Reviewers: dhruba, haobo, kailiu Reviewed By: dhruba CC: leveldb Differential Revision: https://reviews.facebook.net/D14715 --- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 6200144c1..0b113c1b5 100644 --- a/Makefile +++ b/Makefile @@ -49,6 +49,7 @@ VALGRIND_VER := $(join $(VALGRIND_VER),valgrind) VALGRIND_OPTS = --error-exitcode=$(VALGRIND_ERROR) --leak-check=full TESTS = \ + db_test \ table_properties_collector_test \ arena_test \ auto_roll_logger_test \ @@ -81,8 +82,7 @@ TESTS = \ version_set_test \ write_batch_test\ deletefile_test \ - table_test \ - db_test + table_test TOOLS = \ sst_dump \ @@ -147,8 +147,9 @@ coverage: # Delete intermediate files find . -type f -regex ".*\.\(\(gcda\)\|\(gcno\)\)" -exec rm {} \; -check: all $(PROGRAMS) $(TESTS) $(TOOLS) ldb_tests +check: all $(PROGRAMS) $(TESTS) $(TOOLS) for t in $(TESTS); do echo "***** Running $$t"; ./$$t || exit 1; done + python tools/ldb_test.py ldb_tests: all $(PROGRAMS) $(TOOLS) python tools/ldb_test.py