andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make WithParamInterface virtual in transaction_test

Browse Source 
Summary:
Without this patch, ubsan_check is currently failing with this error:
```
utilities/transactions/write_prepared_transaction_test.cc:369:63: runtime error: member call on address 0x0000051649f8 which does not point to an object of type 'WithParamInterface'
0x0000051649f8: note: object has invalid vptr
```
Tested by `COMPILE_WITH_UBSAN=1 make -j32 transaction_test` and running `./write_prepared_transaction_test --gtest_filter=TwoWriteQueues/SnapshotConcurrentAccessTest.SnapshotConcurrentAccessTest1/0`
Closes https://github.com/facebook/rocksdb/pull/3444

Differential Revision: D6850087

Pulled By: maysamyabandeh

fbshipit-source-id: 5b254da8504b8757f7aec8a820ad464154da1a1d
This commit is contained in:
Maysam Yabandeh 2018-01-30 16:19:22 -08:00 committed by Facebook Github Bot
parent ab43ff58b5
commit ec225d2e97
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
utilities/transactions/transaction_test.h
View File

@ -400,7 +400,7 @@ class TransactionTestBase : public ::testing::Test {
};
class TransactionTest : public TransactionTestBase,
public ::testing::WithParamInterface<
virtual public ::testing::WithParamInterface<
std::tuple<bool, bool, TxnDBWritePolicy>> {
public:
TransactionTest()

2
utilities/transactions/write_prepared_transaction_test.cc
View File

@ -360,7 +360,7 @@ class WritePreparedTransactionTest
class SnapshotConcurrentAccessTest
: public WritePreparedTransactionTestBase,
public ::testing::WithParamInterface<
virtual public ::testing::WithParamInterface<
std::tuple<bool, bool, TxnDBWritePolicy, size_t, size_t>> {
public:
SnapshotConcurrentAccessTest()