andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Counters for bytes written and read.

Browse Source 
Summary:
* Counters for bytes read and write.
as a part of this diff, I want to=>
* Measure compaction times. @dhruba can you point which function, should
* I time to get Compaction-times. Was looking at CompactRange.

Test Plan: db_test

Reviewers: dhruba, emayanke

CC: leveldb

Differential Revision: https://reviews.facebook.net/D8763
This commit is contained in:
Abhishek Kona 2013-02-20 19:22:13 -08:00
parent 6abb30d4d0
commit ec77366e14
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
db/db_impl.cc
View File

@ -1855,6 +1855,7 @@ Status DBImpl::Get(const ReadOptions& options,
imm.UnrefAll(); imm.UnrefAll();
current->Unref(); current->Unref();
RecordTick(options_.statistics, NUMBER_KEYS_READ); RecordTick(options_.statistics, NUMBER_KEYS_READ);
RecordTick(options_.statistics, BYTES_READ, value->size());
return s; return s;
} }
@ -1917,7 +1918,9 @@ Status DBImpl::Write(const WriteOptions& options, WriteBatch* my_batch) {
last_sequence += my_batch_count; last_sequence += my_batch_count;
// Record statistics // Record statistics
RecordTick(options_.statistics, NUMBER_KEYS_WRITTEN, my_batch_count); RecordTick(options_.statistics, NUMBER_KEYS_WRITTEN, my_batch_count);
RecordTick(options_.statistics,
BYTES_WRITTEN,
WriteBatchInternal::ByteSize(updates));
// Add to log and apply to memtable. We can release the lock // Add to log and apply to memtable. We can release the lock
// during this phase since &w is currently responsible for logging // during this phase since &w is currently responsible for logging
// and protects against concurrent loggers and concurrent writes // and protects against concurrent loggers and concurrent writes

6
include/leveldb/statistics.h
View File

@ -33,9 +33,13 @@ enum Tickers {
NUMBER_KEYS_WRITTEN = 6, NUMBER_KEYS_WRITTEN = 6,
// Number of Keys read, // Number of Keys read,
NUMBER_KEYS_READ = 7, NUMBER_KEYS_READ = 7,
TICKER_ENUM_MAX = 8, // Bytes written / read
BYTES_WRITTEN = 8,
BYTES_READ = 9,
TICKER_ENUM_MAX = 10,
}; };
/** /**
* Keep adding histogram's here. * Keep adding histogram's here.
* Any histogram whould have value less than HISTOGRAM_ENUM_MAX * Any histogram whould have value less than HISTOGRAM_ENUM_MAX