andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add test DBTest2.GetRaceFlush which can expose a data race bug

Browse Source 
Summary:
A current data race issue in Get() and Flush() can cause a Get() to return wrong results when a flush happened in the middle. Disable the test for now.
Closes https://github.com/facebook/rocksdb/pull/1813

Differential Revision: D4472310

Pulled By: siying

fbshipit-source-id: 5755ebd
This commit is contained in:
Siying Dong 2017-01-26 16:25:19 -08:00 committed by Facebook Github Bot
parent 37d4a79e99
commit f25f1ec60b
2 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
db/db_impl.cc
View File

@ -4007,6 +4007,9 @@ Status DBImpl::GetImpl(const ReadOptions& read_options,
} else { } else {
snapshot = versions_->LastSequence(); snapshot = versions_->LastSequence();
} }
TEST_SYNC_POINT("DBImpl::GetImpl:1");
TEST_SYNC_POINT("DBImpl::GetImpl:2");
// Acquire SuperVersion // Acquire SuperVersion
SuperVersion* sv = GetAndRefSuperVersion(cfd); SuperVersion* sv = GetAndRefSuperVersion(cfd);
// Prepare to store a list of merge operations if merge occurs. // Prepare to store a list of merge operations if merge occurs.

23
db/db_test2.cc
View File

@ -2228,6 +2228,29 @@ TEST_F(DBTest2, OptimizeForPointLookup) {
Flush(); Flush();
ASSERT_EQ("v1", Get("foo")); ASSERT_EQ("v1", Get("foo"));
} }
// Disable the test before we fix the bug
TEST_F(DBTest2, DISABLED_GetRaceFlush) {
ASSERT_OK(Put("foo", "v1"));
rocksdb::SyncPoint::GetInstance()->LoadDependency(
{{"DBImpl::GetImpl:1", "DBTest2::GetRaceFlush:1"},
{"DBTest2::GetRaceFlush:2", "DBImpl::GetImpl:2"}});
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
std::thread threads([&] {
TEST_SYNC_POINT("DBTest2::GetRaceFlush:1");
ASSERT_OK(Put("foo", "v2"));
Flush();
TEST_SYNC_POINT("DBTest2::GetRaceFlush:2");
});
// Get() is issued after the first Put(), so it should see either
// "v1" or "v2".
ASSERT_NE("NOT_FOUND", Get("foo"));
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
}
#endif // ROCKSDB_LITE #endif // ROCKSDB_LITE
} // namespace rocksdb } // namespace rocksdb