Move ~Comparator define to comparator.h
Summary: When I impl my own comparator, and build in release mode. The following compile error occurs. undefined reference to `typeinfo for rocksdb::Comparator' This fix allows users build with RTTI off when has their own comparator. Closes https://github.com/facebook/rocksdb/pull/3008 Differential Revision: D6077354 Pulled By: yiwu-arbug fbshipit-source-id: 914c26dbab72f0ad1f0e15f8666a3fb2f10bfed8
This commit is contained in:
parent
8e63cad078
commit
f7843f30a8
@ -21,7 +21,7 @@ class Slice;
|
|||||||
// from multiple threads.
|
// from multiple threads.
|
||||||
class Comparator {
|
class Comparator {
|
||||||
public:
|
public:
|
||||||
virtual ~Comparator();
|
virtual ~Comparator() {}
|
||||||
|
|
||||||
// Three-way comparison. Returns value:
|
// Three-way comparison. Returns value:
|
||||||
// < 0 iff "a" < "b",
|
// < 0 iff "a" < "b",
|
||||||
|
@ -17,8 +17,6 @@
|
|||||||
|
|
||||||
namespace rocksdb {
|
namespace rocksdb {
|
||||||
|
|
||||||
Comparator::~Comparator() { }
|
|
||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
class BytewiseComparatorImpl : public Comparator {
|
class BytewiseComparatorImpl : public Comparator {
|
||||||
public:
|
public:
|
||||||
|
Loading…
Reference in New Issue
Block a user