andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Move ~Comparator define to comparator.h

Browse Source 
Summary:
When I impl my own comparator, and build in release mode.
The following compile error occurs.
undefined reference to `typeinfo for rocksdb::Comparator'

This fix allows users build with RTTI off when has their own comparator.
Closes https://github.com/facebook/rocksdb/pull/3008

Differential Revision: D6077354

Pulled By: yiwu-arbug

fbshipit-source-id: 914c26dbab72f0ad1f0e15f8666a3fb2f10bfed8
This commit is contained in:
codeeply 2017-10-17 09:50:16 -07:00 committed by Facebook Github Bot
parent 8e63cad078
commit f7843f30a8
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/rocksdb/comparator.h
View File

@ -21,7 +21,7 @@ class Slice;
// from multiple threads. // from multiple threads.
class Comparator { class Comparator {
public: public:
virtual ~Comparator(); virtual ~Comparator() {}
// Three-way comparison. Returns value: // Three-way comparison. Returns value:
// < 0 iff "a" < "b", // < 0 iff "a" < "b",

2
util/comparator.cc
View File

@ -17,8 +17,6 @@
namespace rocksdb { namespace rocksdb {
Comparator::~Comparator() { }
namespace { namespace {
class BytewiseComparatorImpl : public Comparator { class BytewiseComparatorImpl : public Comparator {
public: public: