From f941adef8826268f2ea3d7cb8baef6e49e2f0c45 Mon Sep 17 00:00:00 2001 From: Zhichao Cao Date: Fri, 5 Jun 2020 17:43:31 -0700 Subject: [PATCH] Clean up the dead code (#6946) Summary: Remove the dead code in table test. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6946 Test Plan: run table_test Reviewed By: riversand963 Differential Revision: D21913563 Pulled By: zhichao-cao fbshipit-source-id: c0aa9f3b95dfe87dd7fb2cd4823784f08cb3ddd3 --- table/table_test.cc | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/table/table_test.cc b/table/table_test.cc index d7e95ac5e..e6930eca3 100644 --- a/table/table_test.cc +++ b/table/table_test.cc @@ -3265,17 +3265,9 @@ TEST_P(BlockBasedTableTest, NoFileChecksum) { BlockBasedTableOptions table_options = GetBlockBasedTableOptions(); std::unique_ptr comparator( new InternalKeyComparator(BytewiseComparator())); - SequenceNumber largest_seqno = 0; int level = 0; std::vector> int_tbl_prop_collector_factories; - - if (largest_seqno != 0) { - // Pretend that it's an external file written by SstFileWriter. - int_tbl_prop_collector_factories.emplace_back( - new SstFileWriterPropertiesCollectorFactory(2 /* version */, - 0 /* global_seqno*/)); - } std::string column_family_name; FileChecksumTestHelper f(true); @@ -3307,17 +3299,9 @@ TEST_P(BlockBasedTableTest, Crc32cFileChecksum) { BlockBasedTableOptions table_options = GetBlockBasedTableOptions(); std::unique_ptr comparator( new InternalKeyComparator(BytewiseComparator())); - SequenceNumber largest_seqno = 0; int level = 0; std::vector> int_tbl_prop_collector_factories; - - if (largest_seqno != 0) { - // Pretend that it's an external file written by SstFileWriter. - int_tbl_prop_collector_factories.emplace_back( - new SstFileWriterPropertiesCollectorFactory(2 /* version */, - 0 /* global_seqno*/)); - } std::string column_family_name; FileChecksumGenContext gen_context;