From f9b14be4951e9aad73b7fcbc120b04127fe8511f Mon Sep 17 00:00:00 2001 From: sdong Date: Wed, 20 Jul 2016 11:14:51 -0700 Subject: [PATCH] Re-enable TSAN crash test but only with black box crash test Summary: I tried on my host and TSAN black box test runs well. I didn't see any problem with white box crash test too but it chance of hitting crash point is too low that it may run almost forever. First re-enable black box crash test to unblock the job. Test Plan: Run it locally. Reviewers: kradhakrishnan, andrewkr, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: leveldb, andrewkr, dhruba Differential Revision: https://reviews.facebook.net/D60951 --- build_tools/rocksdb-lego-determinator | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/build_tools/rocksdb-lego-determinator b/build_tools/rocksdb-lego-determinator index 05365f779..5fe9826ed 100755 --- a/build_tools/rocksdb-lego-determinator +++ b/build_tools/rocksdb-lego-determinator @@ -523,6 +523,7 @@ TSAN_UNIT_TEST_COMMANDS="[ # # RocksDB crash test under TSAN +# TODO: run white box crash test too # TSAN_CRASH_TEST_COMMANDS="[ { @@ -534,7 +535,7 @@ TSAN_CRASH_TEST_COMMANDS="[ { 'name':'Compile and run', 'timeout': 86400, - 'shell':'set -o pipefail && $SHM $DEBUG $TSAN make J=1 crash_test', + 'shell':'set -o pipefail && $SHM $DEBUG $TSAN make J=1 blackbox_crash_test', 'user':'root', $PARSER }, @@ -543,8 +544,6 @@ TSAN_CRASH_TEST_COMMANDS="[ } ]" -TSAN_CRASH_TEST_COMMANDS=$DISABLE_COMMANDS - # # RocksDB format compatible #