Summary: ...everyone else seems to send out a diff, so I'm sending out a diff.
Test Plan: n/a
Reviewers: sdong
Reviewed By: sdong
Subscribers: dhruba
Differential Revision: https://reviews.facebook.net/D45573
Summary:
Many people have complained to me saying that they do not know where
the engineering development discussions are occuring.
Test Plan:
Reviewers:
CC:
Task ID: #
Blame Rev:
Summary:
As discussed with Igor, will upload these slides here and share the
links with the community.
Test Plan: n/a
Reviewers: igor
CC: leveldb
Differential Revision: https://reviews.facebook.net/D17421
Summary:
Revise according to recent change.
Also revise .arcconfig as linter codes are deleted from this branch. Otherwise "arc" always fails. This branch is supposed to contain rocksdb.org webpages, no RocksDB source codes. So no linter is fine.
Test Plan: N/A
Reviewers: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D17187
Summary:
Add registration deadline. We need to send guest lists to security
before that.
Test Plan: N/A
Reviewers: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D17085
Summary:
Encourage various vendors to publish their RocksDB benchmark.
This will be a central repositiry that will have links to
vendor-published benchmark results.
Test Plan: none.
Reviewers: xjin, haobo, igor, sdong, jamesgpearce
Reviewed By: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D16677
Summary:
Created a unittest that verifies that automatic deletion performed by PurgeObsoleteFiles() works correctly.
Also, few small fixes on the logic part -- call version_set_->GetObsoleteFiles() in FindObsoleteFiles() instead of on some arbitrary positions.
Test Plan: Created a unit test
Reviewers: dhruba, haobo, nkg-
Reviewed By: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D14079
Summary:
We iterate until we find a different key than original key.
ikey is pointing to next key when we break out of loop.
After the loop we apply all merge operands meant for original key
on the next key!
Test Plan:
Need to give a build to Marcin to test out.
Revert Plan: OK
Task ID: #3181932
Reviewers: haobo, emayanke, dhruba
Reviewed By: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D14073
Summary: https://reviews.facebook.net/D13167 broke bloom filters. If filter is not in cache, we want to return true (safe thing). Am I right?
Test Plan: when benchmarking https://reviews.facebook.net/D14031 I got different results when using bloom filters vs. when not using them. This fixed the issue. I will also be putting this change to the other diff, but that one will probably be in review for longer time.
Reviewers: kailiu, dhruba, haobo
Reviewed By: kailiu
CC: leveldb
Differential Revision: https://reviews.facebook.net/D14085
Summary: This diff leverage the existing block cache and extend it to cache index/filter block.
Test Plan:
Added new tests in db_test and table_test
The correctness is checked by:
1. make check
2. make valgrind_check
Performance is test by:
1. 10 times of build_tools/regression_build_test.sh on two versions of rocksdb before/after the code change. Test results suggests no significant difference between them. For the two key operatons `overwrite` and `readrandom`, the average iops are both 20k and ~260k, with very small variance).
2. db_stress.
Reviewers: dhruba
Reviewed By: dhruba
CC: leveldb, haobo, xjin
Differential Revision: https://reviews.facebook.net/D13167
