60f5a22cff
Summary: Previously we attempted to rename "LOG" to "LOG.old.*" without checking its existence first. "LOG" had no reason to exist in a new DB. Errors in renaming a non-existent "LOG" were swallowed via `PermitUncheckedError()` so things worked. However the storage service's error monitoring was detecting all these benign rename failures. So it is better to fix it. Also with this PR we can now distinguish rename failure for other reasons and return them. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8622 Test Plan: new unit test Reviewed By: akankshamahajan15 Differential Revision: D30115189 Pulled By: ajkr fbshipit-source-id: e2f337ffb2bd171be0203172abc8e16e7809b170 |
||
|---|---|---|
| .. | ||
| auto_roll_logger_test.cc | ||
| auto_roll_logger.cc | ||
| auto_roll_logger.h | ||
| env_logger_test.cc | ||
| env_logger.h | ||
| event_logger_test.cc | ||
| event_logger.cc | ||
| event_logger.h | ||
| log_buffer.cc | ||
| log_buffer.h | ||
| logging.h | ||
| posix_logger.h | ||