andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/util
History
Andrew Kryczka ba7c46a3d8 workaround race conditions during PeriodicWorkScheduler registration (#7888) 
Summary:
This provides a workaround for two race conditions that will be fixed in
a more sophisticated way later. This PR:

(1) Makes the client serialize calls to `Timer::Start()` and `Timer::Shutdown()` (see https://github.com/facebook/rocksdb/issues/7711). The long-term fix will be to make those functions thread-safe.
(2) Makes `PeriodicWorkScheduler` atomically add/cancel work together with starting/shutting down its `Timer`. The long-term fix will be for `Timer` API to offer more specialized APIs so the client will not need to synchronize.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7888

Test Plan: ran the repro provided in https://github.com/facebook/rocksdb/issues/7881

Reviewed By: jay-zhuang

Differential Revision: D25990891

Pulled By: ajkr

fbshipit-source-id: a97fdaebbda6d7db7ddb1b146738b68c16c5be38
2021-01-21 12:35:30 -08:00
..
aligned_buffer.h
Fix wrong comments about function TruncateToPageBoundary. (#6975)
2020-10-07 12:34:34 -07:00
autovector_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
autovector.h
Change autovector to have a reserved size in LITE mode (#6868)
2020-05-21 14:48:10 -07:00
bloom_impl.h
Ribbon: InterleavedSolutionStorage (#7598)
2020-11-03 12:46:36 -08:00
bloom_test.cc
Support optimize_filters_for_memory for Ribbon filter (#7774)
2020-12-18 14:31:03 -08:00
build_version.cc.in
Add copyright headers per FB open-source checkup tool. (#5199)
2019-04-18 10:55:01 -07:00
build_version.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cast_util.h
Replace reinterpret_cast with static_cast_with_check (#7067)
2020-07-02 19:25:41 -07:00
channel.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
coding_lean.h
Add Encode/DecodeFixedGeneric, coding_lean.h (#7587)
2020-10-23 14:11:15 -07:00
coding_test.cc
Fix potential overflow of unsigned type in for loop (#6902)
2020-06-02 15:05:07 -07:00
coding.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
coding.h
Add Encode/DecodeFixedGeneric, coding_lean.h (#7587)
2020-10-23 14:11:15 -07:00
compaction_job_stats_impl.cc
Add is_full_compaction to CompactionJobStats, cleanup (#7451)
2020-10-01 12:52:58 -07:00
comparator.cc
Remove unused includes (#7604)
2020-10-28 23:22:27 -07:00
compression_context_cache.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
compression_context_cache.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
compression.h
Expand effect of dictionary settings in ColumnFamilyOptions::compression_opts (#7619)
2020-11-02 19:21:11 -08:00
concurrent_task_limiter_impl.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
concurrent_task_limiter_impl.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
core_local.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
crc32c_arm64.cc
Adding ARM AT_HWCAP support for FreeBSD (#7750)
2020-12-08 13:33:21 -08:00
crc32c_arm64.h
Fix compilation on Apple Silicon (#7714)
2020-12-04 15:22:33 -08:00
crc32c_ppc_asm.S
Fix Compilation on ppc64le using Clang 11 (#7713)
2020-12-01 11:21:44 -08:00
crc32c_ppc_constants.h
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
crc32c_ppc.c
Fix Compilation on ppc64le using Clang 11 (#7713)
2020-12-01 11:21:44 -08:00
crc32c_ppc.h
Fix Compilation on ppc64le using Clang 11 (#7713)
2020-12-01 11:21:44 -08:00
crc32c_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
crc32c.cc
Fix build on FreeBSD/powerpc64(le) (#7732)
2020-12-08 15:31:56 -08:00
crc32c.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
defer_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
defer.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
duplicate_detector.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
dynamic_bloom_test.cc
Remove unused includes (#7604)
2020-10-28 23:22:27 -07:00
dynamic_bloom.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
dynamic_bloom.h
Genericize and clean up FastRange (#7436)
2020-09-28 11:35:00 -07:00
fastrange.h
Genericize and clean up FastRange (#7436)
2020-09-28 11:35:00 -07:00
file_checksum_helper.cc
Refactor with VersionEditHandler (#6581)
2020-11-11 08:00:14 -08:00
file_checksum_helper.h
Real fix for race in backup custom checksum checking (#7309)
2020-08-26 10:39:20 -07:00
file_reader_writer_test.cc
Check status for file_reader_writer_test (#7449)
2020-09-28 16:05:11 -07:00
filelock_test.cc
Fix MSVC-related build issues (#7439)
2020-10-01 09:23:04 -07:00
filter_bench.cc
Use size_t for filter APIs, protect against overflow (#7726)
2020-12-11 22:18:12 -08:00
gflags_compat.h
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
2020-10-27 10:33:09 -07:00
hash_map.h
Change HashMap::Insert()'s value to a const reference (#6567)
2020-03-20 14:59:54 -07:00
hash_test.cc
Use NPHash64 in more places (#7632)
2020-11-10 23:42:13 -08:00
hash.cc
C++20 compatibility (#6697)
2020-04-20 13:24:25 -07:00
hash.h
Use NPHash64 in more places (#7632)
2020-11-10 23:42:13 -08:00
heap_test.cc
Revert "Update googletest from 1.8.1 to 1.10.0 (#6808)" (#6923)
2020-06-03 15:55:03 -07:00
heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
kv_map.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
log_write_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
math128.h
Ribbon: InterleavedSolutionStorage (#7598)
2020-11-03 12:46:36 -08:00
math.h
Fix MSVC-related build issues (#7439)
2020-10-01 09:23:04 -07:00
murmurhash.cc
C++20 compatibility (#6697)
2020-04-20 13:24:25 -07:00
murmurhash.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
mutexlock.h
Prevents Table Cache to open same files more times (#6707)
2020-04-21 13:16:31 -07:00
ppc-opcode.h
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
random_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
random.cc
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
random.h
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
rate_limiter_test.cc
Skip minimum rate check in Sandcastle (#7728)
2020-12-02 15:16:49 -08:00
rate_limiter.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
rate_limiter.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
repeatable_thread_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
repeatable_thread.h
Fix a timer_test deadlock (#7277)
2020-08-20 08:43:13 -07:00
ribbon_alg.h
Ribbon: major re-work of hashing, seeds, and more (#7635)
2020-11-07 17:22:54 -08:00
ribbon_impl.h
Support optimize_filters_for_memory for Ribbon filter (#7774)
2020-12-18 14:31:03 -08:00
ribbon_test.cc
Experimental (production candidate) SST schema for Ribbon filter (#7658)
2020-11-12 20:46:14 -08:00
set_comparator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
slice_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
slice_transform_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
slice.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
status.cc
Add a new IOStatus subcode to indicate that writes are fenced off (#7374)
2020-09-14 16:04:47 -07:00
stderr_logger.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
stop_watch.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
string_util.cc
Remove unused includes (#7604)
2020-10-28 23:22:27 -07:00
string_util.h
Add Struct Type to OptionsTypeInfo (#6425)
2020-05-21 10:58:39 -07:00
thread_list_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_local_test.cc
Fix ThreadLocalTest.SequentialReadWriteTest failure when running individually (#6929)
2020-06-04 11:44:09 -07:00
thread_local.cc
Fix typo in ThreadData comment (#7131)
2020-07-15 09:23:23 -07:00
thread_local.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_operation.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
threadpool_imp.cc
Make it able to lower cpu priority to specific level in threadpool (#6969)
2020-06-13 13:25:20 -07:00
threadpool_imp.h
Make it able to lower cpu priority to specific level in threadpool (#6969)
2020-06-13 13:25:20 -07:00
timer_queue_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
timer_queue.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
timer_test.cc
Bring the Configurable options together (#5753)
2020-09-14 17:01:01 -07:00
timer.h
workaround race conditions during PeriodicWorkScheduler registration (#7888)
2021-01-21 12:35:30 -08:00
user_comparator_wrapper.h
Separate internal and user key comparators in BlockIter (#6944)
2020-07-07 17:26:16 -07:00
vector_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
work_queue_test.cc
Add pipelined & parallel compression optimization (#6262)
2020-04-01 16:40:18 -07:00
work_queue.h
Revamp cache_bench to resemble a real workload (#6629)
2020-04-03 10:26:49 -07:00
xxh3p.h
Fix MSVC-related build issues (#7439)
2020-10-01 09:23:04 -07:00
xxhash.cc
Remove unused includes (#7604)
2020-10-28 23:22:27 -07:00
xxhash.h
Misc hashing updates / upgrades (#5909)
2019-10-24 17:16:46 -07:00