andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
03b08ba9a9
rocksdb/tools
History
Yueh-Hsuan Chiang a263002a36 Fixed a tsan warning in db_stress.cc 
Summary:
Fixed the following tsan warning in db_stress.cc

  WARNING: ThreadSanitizer: data race (pid=3163194)
  Read of size 8 at 0x7fd1797cb518 by thread T32:
    #0 VerifyDb tools/db_stress.cc:1731 (db_stress+0x000000040674)
    #1 rocksdb::StressTest::ThreadBody(void*) tools/db_stress.cc:1191 (db_stress+0x0000000625a9)
    #2 StartThreadWrapper util/env_posix.cc:1648 (db_stress+0x00000028bbbd)

  Previous write of size 8 at 0x7fd1797cb518 by thread T31:
    #0 VerifyDb tools/db_stress.cc:1726 (db_stress+0x00000004072a)
    #1 rocksdb::StressTest::ThreadBody(void*) tools/db_stress.cc:1191 (db_stress+0x0000000625a9)
    #2 StartThreadWrapper util/env_posix.cc:1648 (db_stress+0x00000028bbbd)

The cause is that in VerifyDb(), the static local const variable long max_key
can be read and written at the same time.  This patch fixed it by making it
non-static.

Test Plan: db_stress

Reviewers: igor, sdong, IslamAbdelRahman, anthony

Reviewed By: anthony

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D47703
2015-09-28 12:06:43 -07:00
..
dump Fix mac compile 2015-06-26 10:29:24 -07:00
rdb first rdb commit 2014-11-20 23:33:00 -05:00
auto_sanity_test.sh Make auto_sanity_test always use the db_sanity_test.cc of the newer commit. 2015-03-27 11:32:49 -07:00
benchmark_leveldb.sh Add scripts to run leveldb benchmark 2015-04-27 19:32:56 -07:00
benchmark.sh Fix benchmark report script 2015-08-22 12:18:00 -07:00
check_format_compatible.sh Script to check whether RocksDB can read DB generated by previous releases and vice versa 2015-04-08 16:04:59 -07:00
db_crashtest2.py crash_test cleans up directory before testing if TEST_TMPDIR is set 2015-08-04 14:59:28 -07:00
db_crashtest.py crash_test cleans up directory before testing if TEST_TMPDIR is set 2015-08-04 14:59:28 -07:00
db_repl_stress.cc "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
db_sanity_test.cc Add ZSTD (not final format) compression type 2015-08-28 11:01:13 -07:00
db_stress.cc Fixed a tsan warning in db_stress.cc 2015-09-28 12:06:43 -07:00
dbench_monitor Added simple monitoring script to monitor overusage of memory in db_bench 2015-02-11 18:40:11 -08:00
Dockerfile adding docker build script and dockerfile 2015-05-22 16:03:39 -07:00
generate_random_db.sh Script to check whether RocksDB can read DB generated by previous releases and vice versa 2015-04-08 16:04:59 -07:00
ldb_test.py Tests for ManifestDumpCommand and ListColumnFamiliesCommand 2015-09-08 14:23:42 -07:00
ldb.cc Make db_stress built for ROCKSDB_LITE 2014-11-14 10:20:51 -08:00
pflag Added simple monitoring script to monitor overusage of memory in db_bench 2015-02-11 18:40:11 -08:00
reduce_levels_test.cc Don't let flushes preempt compactions 2015-07-17 12:02:52 -07:00
rocksdb_dump_test.sh First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
run_flash_bench.sh Improve defaults for benchmarks 2015-08-20 18:59:10 -07:00
run_leveldb.sh Add scripts to run leveldb benchmark 2015-04-27 19:32:56 -07:00
sample-dump.dmp First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
sst_dump.cc Make db_stress built for ROCKSDB_LITE 2014-11-14 10:20:51 -08:00
verify_random_db.sh Script to check whether RocksDB can read DB generated by previous releases and vice versa 2015-04-08 16:04:59 -07:00