A library that provides an embeddable, persistent key-value store for fast storage.
Go to file
Igor Sugak 03b432d4b8 rocksdb: Fix uninitialized use error
Summary:
When using latest clang (3.6 or 3.7/trunck) rocksdb is failing with many errors. Some errors are uninitialized use errors.

```
...
  CC       db/log_test.o
util/ldb_cmd.cc:394:16: error: base class 'rocksdb::LDBCommand' is uninitialized when used here to access 'rocksdb::LDBCommand::BuildCmdLineOptions' [-Werror,-Wuninitialized]
               BuildCmdLineOptions({ARG_FROM, ARG_TO, ARG_HEX, ARG_KEY_HEX,
               ^
...
```

```lang=c++
CompactorCommand::CompactorCommand(const vector<string>& params,
      const map<string, string>& options, const vector<string>& flags) :
    LDBCommand(options, flags, false,
               BuildCmdLineOptions({ARG_FROM, ARG_TO, ARG_HEX, ARG_KEY_HEX,
                                    ARG_VALUE_HEX, ARG_TTL})),
    null_from_(true), null_to_(true) {
. . .
}
```
For the fourth parameter of the base constructor (`LDBCommand`) we call `BuildCmdLineOptions`, which is a private non-static method of `LDBCommand` base class.

This diff adds missing `static` keyword for `LDBCommand::BuildCmdLineOptions` method.

Test Plan:
Build with trunk clang and make sure all tests are passing.
```lang=bash
% # Have trunk clang present in path.
% ROCKSDB_NO_FBCODE=1 CC=clang CXX=clang++ make check
``

Reviewers: meyering, sdong, rven, igor

Reviewed By: igor

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D34083
2015-02-26 14:19:51 -08:00
build_tools Support builds for MongoDB+RocksDB 2015-02-26 10:50:03 -08:00
coverage Fix coverage script 2014-11-03 14:53:00 -08:00
db rocksdb: Add missing override 2015-02-26 11:28:41 -08:00
doc Remove seek compaction 2014-06-20 10:23:02 +02:00
examples Fix formatting 2015-02-09 09:53:30 -08:00
hdfs rocksdb: Add missing override 2015-02-26 11:28:41 -08:00
include Return fbson 2015-02-27 00:04:14 +03:00
java [RocksJava] RocksJava Testcases 2015-02-26 22:35:26 +01:00
linters Return fbson 2015-02-27 00:04:14 +03:00
port LevelDb include guard replaced with #pragma once 2015-02-24 09:05:06 +03:00
table rocksdb: Add missing override 2015-02-26 11:28:41 -08:00
third-party/fbson Return fbson 2015-02-27 00:04:14 +03:00
tools rocksdb: Add missing override 2015-02-26 11:28:41 -08:00
util rocksdb: Fix uninitialized use error 2015-02-26 14:19:51 -08:00
utilities Return fbson 2015-02-27 00:04:14 +03:00
.arcconfig build: abbreviate AR command, too 2015-02-19 11:48:09 -08:00
.clang-format A script that automatically reformat affected lines 2014-01-14 12:21:24 -08:00
.gitignore rocksdb: changes to support 'make analyze' in Jenkins 2015-02-23 17:45:25 -08:00
.travis.yml Upgrade compiler in Travis 2015-02-24 17:19:58 -08:00
AUTHORS Add AUTHORS file. Fix #203 2014-09-29 10:52:18 -07:00
CONTRIBUTING.md facebook accounts are not required for CLA signers 2014-07-08 05:57:54 -04:00
HISTORY.md Remember whole key/prefix filtering on/off in SST file 2015-02-11 11:20:04 -08:00
INSTALL.md Optimize default compile to compilation platform by default 2014-12-15 11:29:41 +01:00
LICENSE Fix copyright year 2014-03-12 12:06:58 -07:00
Makefile Introduce DISABLE_WARNING_AS_ERROR in Makefile 2015-02-24 09:52:28 -08:00
PATENTS Fix the patent format 2013-10-16 15:37:32 -07:00
README.md Replaced "built on on earlier work" by "built on earlier work" in README.md 2014-09-17 01:16:17 -07:00
ROCKSDB_LITE.md RocksDBLite 2014-04-15 13:39:26 -07:00
Vagrantfile Package generation for Ubuntu and CentOS 2014-09-29 16:09:46 -07:00

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Build Status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/