469a9f32a7
Summary: These bugs were caught by ASAN crash test. 1. The first one, in table/filter_block.cc is very nasty. We first reference entries_ and store the reference to Slice prev. Then, we call entries_.append(), which can change the reference. The Slice prev now points to junk. 2. The second one is a bug in a test, so it's not very serious. Once we set read_opts.prefix, we never clear it, so some other function might still reference it. Test Plan: asan crash test now runs more than 5 mins. Before, it failed immediately. I will run the full one, but the full one takes quite some time (5 hours) Reviewers: dhruba, haobo, kailiu Reviewed By: dhruba CC: leveldb Differential Revision: https://reviews.facebook.net/D14223 |
||
---|---|---|
.. | ||
shell | ||
blob_store_bench.cc | ||
db_crashtest2.py | ||
db_crashtest.py | ||
db_repl_stress.cc | ||
db_stress.cc | ||
ldb_test.py | ||
ldb.cc | ||
reduce_levels_test.cc | ||
sst_dump.cc |