04623e7cd4
Summary: Fixes https://github.com/facebook/rocksdb/issues/9066. Prior to the fix in this PR, this PR's unit test reported the following error under ASAN: ``` ==2175705==ERROR: AddressSanitizer: heap-use-after-free on address 0x61f0000012a5 at pc 0x7f0fc36e76ce bp 0x7ffc103e9ca0 sp 0x7ffc103e9450 READ of size 5 at 0x61f0000012a5 thread T0 #0 0x7f0fc36e76cd in __interceptor_memcpy /home/engshare/third-party2/gcc/9.x/src/gcc-10.x/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:790 https://github.com/facebook/rocksdb/issues/1 0x7f0fc35a207e in std::char_traits<char>::copy(char*, char const*, unsigned long) /home/engshare/third-party2/libgcc/9.x/src/gcc-9.x/x86_64-facebook-linux/libstdc++-v3/include/bits/char_traits.h:365 https://github.com/facebook/rocksdb/issues/2 0x7f0fc35a207e in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_copy(char*, char const*, unsigned long) /home/engshare/third-party2/libgcc/9.x/src/gcc-9.x/x86_64-facebook-linux/libstdc++-v3/include/bits/basic_string.h:351 https://github.com/facebook/rocksdb/issues/3 0x7f0fc35a207e in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace(unsigned long, unsigned long, char const*, unsigned long) /home/engshare/third-party2/libgcc/9.x/src/gcc-9.x/x86_64-facebook-linux/libstdc++-v3/include/bits/basic_string.tcc:440 https://github.com/facebook/rocksdb/issues/4 0x8679ca in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::assign(char const*, unsigned long) /mnt/gvfs/third-party2/libgcc/4959b39cfbe5965a37c861c4c327fa7c5c759b87/9.x/platform009/9202ce7/include/c++/9.3.0/bits/basic_string.h:1422 https://github.com/facebook/rocksdb/issues/5 0x8679ca in rocksdb::PinnableSlice::PinSelf(rocksdb::Slice const&) include/rocksdb/slice.h:171 https://github.com/facebook/rocksdb/issues/6 0x8679ca in rocksdb::DBImpl::GetImpl(rocksdb::ReadOptions const&, rocksdb::Slice const&, rocksdb::DBImpl::GetImplOptions&) db/db_impl/db_impl.cc:1930 https://github.com/facebook/rocksdb/issues/7 0x547324 in rocksdb::DBImpl::GetMergeOperands(rocksdb::ReadOptions const&, rocksdb::ColumnFamilyHandle*, rocksdb::Slice const&, rocksdb::PinnableSlice*, rocksdb::GetMergeOperandsOptions*, int*) db/db_impl/db_impl.h:203 https://github.com/facebook/rocksdb/issues/8 0x547324 in rocksdb::DBMergeOperandTest_FlushedMergeOperandReadAfterFreeBug_Test::TestBody() db/db_merge_operand_test.cc:117 https://github.com/facebook/rocksdb/issues/9 0x7241da in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3899 https://github.com/facebook/rocksdb/issues/10 0x7241da in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3935 https://github.com/facebook/rocksdb/issues/11 0x701a47 in testing::Test::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3973 https://github.com/facebook/rocksdb/issues/12 0x702040 in testing::Test::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3965 https://github.com/facebook/rocksdb/issues/13 0x702040 in testing::TestInfo::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4149 https://github.com/facebook/rocksdb/issues/14 0x7025f7 in testing::TestInfo::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4124 https://github.com/facebook/rocksdb/issues/15 0x7025f7 in testing::TestCase::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4267 https://github.com/facebook/rocksdb/issues/16 0x704217 in testing::TestCase::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4253 https://github.com/facebook/rocksdb/issues/17 0x704217 in testing::internal::UnitTestImpl::RunAllTests() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:6633 https://github.com/facebook/rocksdb/issues/18 0x72505a in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3899 https://github.com/facebook/rocksdb/issues/19 0x72505a in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3935 https://github.com/facebook/rocksdb/issues/20 0x704aa1 in testing::UnitTest::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:6242 https://github.com/facebook/rocksdb/issues/21 0x4c4aff in RUN_ALL_TESTS() third-party/gtest-1.8.1/fused-src/gtest/gtest.h:22110 https://github.com/facebook/rocksdb/issues/22 0x4c4aff in main db/db_merge_operand_test.cc:404 https://github.com/facebook/rocksdb/issues/23 0x7f0fc3108dc4 in __libc_start_main ../csu/libc-start.c:308 https://github.com/facebook/rocksdb/issues/24 0x5445fd in _start (/data/users/andrewkr/rocksdb/db_merge_operand_test+0x5445fd) 0x61f0000012a5 is located 1061 bytes inside of 3264-byte region [0x61f000000e80,0x61f000001b40) freed by thread T0 here: #0 0x7f0fc375b6af in operator delete(void*, unsigned long) /home/engshare/third-party2/gcc/9.x/src/gcc-10.x/libsanitizer/asan/asan_new_delete.cc:177 https://github.com/facebook/rocksdb/issues/1 0x743be8 in rocksdb::SuperVersion::~SuperVersion() db/column_family.cc:432 https://github.com/facebook/rocksdb/issues/2 0x8052aa in rocksdb::DBImpl::CleanupSuperVersion(rocksdb::SuperVersion*) db/db_impl/db_impl.cc:3534 https://github.com/facebook/rocksdb/issues/3 0x8676c2 in rocksdb::DBImpl::ReturnAndCleanupSuperVersion(rocksdb::ColumnFamilyData*, rocksdb::SuperVersion*) db/db_impl/db_impl.cc:3544 https://github.com/facebook/rocksdb/issues/4 0x8676c2 in rocksdb::DBImpl::GetImpl(rocksdb::ReadOptions const&, rocksdb::Slice const&, rocksdb::DBImpl::GetImplOptions&) db/db_impl/db_impl.cc:1911 https://github.com/facebook/rocksdb/issues/5 0x547324 in rocksdb::DBImpl::GetMergeOperands(rocksdb::ReadOptions const&, rocksdb::ColumnFamilyHandle*, rocksdb::Slice const&, rocksdb::PinnableSlice*, rocksdb::GetMergeOperandsOptions*, int*) db/db_impl/db_impl.h:203 https://github.com/facebook/rocksdb/issues/6 0x547324 in rocksdb::DBMergeOperandTest_FlushedMergeOperandReadAfterFreeBug_Test::TestBody() db/db_merge_operand_test.cc:117 https://github.com/facebook/rocksdb/issues/7 0x7241da in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3899 https://github.com/facebook/rocksdb/issues/8 0x7241da in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3935 https://github.com/facebook/rocksdb/issues/9 0x701a47 in testing::Test::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3973 https://github.com/facebook/rocksdb/issues/10 0x702040 in testing::Test::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3965 https://github.com/facebook/rocksdb/issues/11 0x702040 in testing::TestInfo::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4149 https://github.com/facebook/rocksdb/issues/12 0x7025f7 in testing::TestInfo::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4124 https://github.com/facebook/rocksdb/issues/13 0x7025f7 in testing::TestCase::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4267 https://github.com/facebook/rocksdb/issues/14 0x704217 in testing::TestCase::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:4253 https://github.com/facebook/rocksdb/issues/15 0x704217 in testing::internal::UnitTestImpl::RunAllTests() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:6633 https://github.com/facebook/rocksdb/issues/16 0x72505a in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3899 https://github.com/facebook/rocksdb/issues/17 0x72505a in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:3935 https://github.com/facebook/rocksdb/issues/18 0x704aa1 in testing::UnitTest::Run() third-party/gtest-1.8.1/fused-src/gtest/gtest-all.cc:6242 https://github.com/facebook/rocksdb/issues/19 0x4c4aff in RUN_ALL_TESTS() third-party/gtest-1.8.1/fused-src/gtest/gtest.h:22110 https://github.com/facebook/rocksdb/issues/20 0x4c4aff in main db/db_merge_operand_test.cc:404 https://github.com/facebook/rocksdb/issues/21 0x7f0fc3108dc4 in __libc_start_main ../csu/libc-start.c:308 https://github.com/facebook/rocksdb/issues/22 0x5445fd in _start (/data/users/andrewkr/rocksdb/db_merge_operand_test+0x5445fd) ... ``` Pull Request resolved: https://github.com/facebook/rocksdb/pull/9805 Test Plan: following the fix in this PR, the new unit test passes Reviewed By: jay-zhuang Differential Revision: D35388415 Pulled By: ajkr fbshipit-source-id: b39c5d002155906c8abc4a3429eca696dbf916d0 |
||
---|---|---|
.. | ||
blob | ||
compaction | ||
db_impl | ||
arena_wrapped_db_iter.cc | ||
arena_wrapped_db_iter.h | ||
builder.cc | ||
builder.h | ||
c_test.c | ||
c.cc | ||
column_family_test.cc | ||
column_family.cc | ||
column_family.h | ||
compact_files_test.cc | ||
comparator_db_test.cc | ||
convenience.cc | ||
corruption_test.cc | ||
cuckoo_table_db_test.cc | ||
db_basic_test.cc | ||
db_block_cache_test.cc | ||
db_bloom_filter_test.cc | ||
db_compaction_filter_test.cc | ||
db_compaction_test.cc | ||
db_dynamic_level_test.cc | ||
db_encryption_test.cc | ||
db_filesnapshot.cc | ||
db_flush_test.cc | ||
db_info_dumper.cc | ||
db_info_dumper.h | ||
db_inplace_update_test.cc | ||
db_io_failure_test.cc | ||
db_iter_stress_test.cc | ||
db_iter_test.cc | ||
db_iter.cc | ||
db_iter.h | ||
db_iterator_test.cc | ||
db_kv_checksum_test.cc | ||
db_log_iter_test.cc | ||
db_logical_block_size_cache_test.cc | ||
db_memtable_test.cc | ||
db_merge_operand_test.cc | ||
db_merge_operator_test.cc | ||
db_options_test.cc | ||
db_properties_test.cc | ||
db_range_del_test.cc | ||
db_rate_limiter_test.cc | ||
db_secondary_test.cc | ||
db_sst_test.cc | ||
db_statistics_test.cc | ||
db_table_properties_test.cc | ||
db_tailing_iter_test.cc | ||
db_test2.cc | ||
db_test_util.cc | ||
db_test_util.h | ||
db_test.cc | ||
db_universal_compaction_test.cc | ||
db_wal_test.cc | ||
db_with_timestamp_basic_test.cc | ||
db_with_timestamp_compaction_test.cc | ||
db_write_buffer_manager_test.cc | ||
db_write_test.cc | ||
dbformat_test.cc | ||
dbformat.cc | ||
dbformat.h | ||
deletefile_test.cc | ||
error_handler_fs_test.cc | ||
error_handler.cc | ||
error_handler.h | ||
event_helpers.cc | ||
event_helpers.h | ||
experimental.cc | ||
external_sst_file_basic_test.cc | ||
external_sst_file_ingestion_job.cc | ||
external_sst_file_ingestion_job.h | ||
external_sst_file_test.cc | ||
fault_injection_test.cc | ||
file_indexer_test.cc | ||
file_indexer.cc | ||
file_indexer.h | ||
filename_test.cc | ||
flush_job_test.cc | ||
flush_job.cc | ||
flush_job.h | ||
flush_scheduler.cc | ||
flush_scheduler.h | ||
forward_iterator_bench.cc | ||
forward_iterator.cc | ||
forward_iterator.h | ||
history_trimming_iterator.h | ||
import_column_family_job.cc | ||
import_column_family_job.h | ||
import_column_family_test.cc | ||
internal_stats.cc | ||
internal_stats.h | ||
job_context.h | ||
kv_checksum.h | ||
listener_test.cc | ||
log_format.h | ||
log_reader.cc | ||
log_reader.h | ||
log_test.cc | ||
log_writer.cc | ||
log_writer.h | ||
logs_with_prep_tracker.cc | ||
logs_with_prep_tracker.h | ||
lookup_key.h | ||
malloc_stats.cc | ||
malloc_stats.h | ||
manual_compaction_test.cc | ||
memtable_list_test.cc | ||
memtable_list.cc | ||
memtable_list.h | ||
memtable.cc | ||
memtable.h | ||
merge_context.h | ||
merge_helper_test.cc | ||
merge_helper.cc | ||
merge_helper.h | ||
merge_operator.cc | ||
merge_test.cc | ||
obsolete_files_test.cc | ||
options_file_test.cc | ||
output_validator.cc | ||
output_validator.h | ||
perf_context_test.cc | ||
periodic_work_scheduler_test.cc | ||
periodic_work_scheduler.cc | ||
periodic_work_scheduler.h | ||
pinned_iterators_manager.h | ||
plain_table_db_test.cc | ||
pre_release_callback.h | ||
prefix_test.cc | ||
range_del_aggregator_bench.cc | ||
range_del_aggregator_test.cc | ||
range_del_aggregator.cc | ||
range_del_aggregator.h | ||
range_tombstone_fragmenter_test.cc | ||
range_tombstone_fragmenter.cc | ||
range_tombstone_fragmenter.h | ||
read_callback.h | ||
repair_test.cc | ||
repair.cc | ||
snapshot_checker.h | ||
snapshot_impl.cc | ||
snapshot_impl.h | ||
table_cache.cc | ||
table_cache.h | ||
table_properties_collector_test.cc | ||
table_properties_collector.cc | ||
table_properties_collector.h | ||
transaction_log_impl.cc | ||
transaction_log_impl.h | ||
trim_history_scheduler.cc | ||
trim_history_scheduler.h | ||
version_builder_test.cc | ||
version_builder.cc | ||
version_builder.h | ||
version_edit_handler.cc | ||
version_edit_handler.h | ||
version_edit_test.cc | ||
version_edit.cc | ||
version_edit.h | ||
version_set_test.cc | ||
version_set.cc | ||
version_set.h | ||
version_util.h | ||
wal_edit_test.cc | ||
wal_edit.cc | ||
wal_edit.h | ||
wal_manager_test.cc | ||
wal_manager.cc | ||
wal_manager.h | ||
write_batch_base.cc | ||
write_batch_internal.h | ||
write_batch_test.cc | ||
write_batch.cc | ||
write_callback_test.cc | ||
write_callback.h | ||
write_controller_test.cc | ||
write_controller.cc | ||
write_controller.h | ||
write_thread.cc | ||
write_thread.h |