rocksdb/build_tools
Peter Dillinger fd3e0f43b3 Require C++17 (#9481)
Summary:
Drop support for some old compilers by requiring C++17 standard
(or higher). See https://github.com/facebook/rocksdb/issues/9388

First modification based on this is to remove some conditional compilation in slice.h (also
better for ODR)

Also in this PR:
* Fix some Makefile formatting that seems to affect ASSERT_STATUS_CHECKED config in
some cases
* Add c_test to NON_PARALLEL_TEST in Makefile
* Fix a clang-analyze reported "potential leak" in lru_cache_test
* Better "compatibility" definition of DEFINE_uint32 for old versions of gflags
* Fix a linking problem with shared libraries in Makefile (`./random_test: error while loading shared libraries: librocksdb.so.6.29: cannot open shared object file: No such file or directory`)
* Always set ROCKSDB_SUPPORT_THREAD_LOCAL and use thread_local (from C++11)
  * TODO in later PR: clean up that obsolete flag
* Fix a cosmetic typo in c.h (https://github.com/facebook/rocksdb/issues/9488)

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9481

Test Plan:
CircleCI config substantially updated.

* Upgrade to latest Ubuntu images for each release
* Generally prefer Ubuntu 20, but keep a couple Ubuntu 16 builds with oldest supported
compilers, to ensure compatibility
* Remove .circleci/cat_ignore_eagain except for Ubuntu 16 builds, because this is to work
around a kernel bug that should not affect anything but Ubuntu 16.
* Remove designated gcc-9 build, because the default linux build now uses GCC 9 from
Ubuntu 20.
* Add some `apt-key add` to fix some apt "couldn't be verified" errors
* Generally drop SKIP_LINK=1; work-around no longer needed
* Generally `add-apt-repository` before `apt-get update` as manual testing indicated the
reverse might not work.

Travis:
* Use gcc-7 by default (remove specific gcc-7 and gcc-4.8 builds)
* TODO in later PR: fix s390x "Assembler messages: Error: invalid switch -march=z14" failure

AppVeyor:
* Completely dropped because we are dropping VS2015 support and CircleCI covers
VS >= 2017

Also local testing with old gflags (out of necessity when using ROCKSDB_NO_FBCODE=1).

Reviewed By: mrambacher

Differential Revision: D33946377

Pulled By: pdillinger

fbshipit-source-id: ae077c823905b45370a26c0103ada119459da6c1
2022-02-04 17:13:10 -08:00
..
amalgamate.py Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
build_detect_platform Require C++17 (#9481) 2022-02-04 17:13:10 -08:00
check-sources.sh Add check for using namespace (#9383) 2022-01-12 13:28:24 -08:00
dependencies_4.8.1.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
dependencies_platform007.sh PosixRandomAccessFile::MultiRead() to use I/O uring if supported (#5881) 2019-12-07 20:55:52 -08:00
dependencies_platform009.sh Add microbench build support for fbcode (#8954) 2021-09-24 10:23:35 -07:00
dependencies.sh Update dependencies (#5777) 2019-09-16 20:44:47 -07:00
dockerbuild.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
error_filter.py Enable txn in crash tests (#6155) 2019-12-11 16:01:55 -08:00
fb_compile_mongo.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
fbcode_config4.8.1.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
fbcode_config_platform007.sh Disable DistributedMutex test by default (#8584) 2021-07-23 15:55:23 -07:00
fbcode_config_platform009.sh Add microbench build support for fbcode (#8954) 2021-09-24 10:23:35 -07:00
fbcode_config.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
format-diff.sh Make format-diff.sh locale-independent (#9079) 2021-10-27 12:26:36 -07:00
gnu_parallel More improvements to output for CircleCI (#9201) 2021-11-23 22:10:27 -08:00
make_package.sh Use standard variables for installing/uninstalling with make (#7187) 2020-08-28 14:47:31 -07:00
precommit_checker.py build_tools/precommit_checker.py: don't hard-code a platform-afflicted python path (#6124) 2019-12-05 11:49:17 -08:00
regression_build_test.sh Remove deprecated API AdvancedColumnFamilyOptions::soft_rate_limit/hard_rate_limit (#9452) 2022-01-27 13:01:09 -08:00
rocksdb-lego-determinator Enable core dumps in ASAN crash tests (#9330) 2021-12-22 10:14:16 -08:00
run_ci_db_test.ps1 Extract test cases correctly in run_ci_db_test.ps1 script (#7989) 2021-02-23 14:25:42 -08:00
setup_centos7.sh Adding new build script for CentOS 7 (#6617) 2020-04-06 16:20:27 -07:00
update_dependencies.sh PosixRandomAccessFile::MultiRead() to use I/O uring if supported (#5881) 2019-12-07 20:55:52 -08:00
version.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00