07a00828af
Summary:
There are some time-related POSIX APIs that are not available on Windows
(e.g. `localtime_r`), which we have worked around by providing our own
implementations in `port/sys_time.h`. This workaround actually relies on
some ambiguity: on Windows, a call to `localtime_r` calls
`ROCKSDB_NAMESPACE::port::localtime_r` (which is pulled into
`ROCKSDB_NAMESPACE` by a using-declaration), while on other platforms
it calls the global `localtime_r`. This works fine as long as there is only one
candidate function; however, it breaks down when there is more than one
`localtime_r` visible in a scope.
The patch fixes this by introducing `ROCKSDB_NAMESPACE::port::{TimeVal, GetTimeOfDay, LocalTimeR}`
to eliminate any ambiguity.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/10045
Test Plan: `make check`
Reviewed By: riversand963
Differential Revision: D36639372
Pulled By: ltamasi
fbshipit-source-id: fc13dbfa421b7c8918111a6d9e24ce77e91a7c50
|
||
|---|---|---|
| .. | ||
| auto_roll_logger_test.cc | ||
| auto_roll_logger.cc | ||
| auto_roll_logger.h | ||
| env_logger_test.cc | ||
| env_logger.h | ||
| event_logger_test.cc | ||
| event_logger.cc | ||
| event_logger.h | ||
| log_buffer.cc | ||
| log_buffer.h | ||
| logging.h | ||
| posix_logger.h | ||