sdong 712bc4b6a2 Fix regression bug in partitioned index reseek caused by #6531 (#6551) ... Summary: https://github.com/facebook/rocksdb/pull/6531 removed some code in partitioned index seek logic. By mistake the logic of storing previous index offset is removed, while the logic of using it is preserved, so that the code might use wrong value to determine reseeking condition. This will trigger a bug, if following a Seek() not going to the last block, SeekToLast() is called, and then Seek() is called which should position the cursor to the block before SeekToLast(). Pull Request resolved: https://github.com/facebook/rocksdb/pull/6551 Test Plan: Add a unit test that reproduces the bug. In the same unit test, also some reseek cases are covered to avoid regression. Reviewed By: pdillinger Differential Revision: D20493990 fbshipit-source-id: 3919aa4861c0481ec96844e053048da1a934b91d		2020-03-17 12:33:10 -07:00
..
binary_search_index_reader.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
binary_search_index_reader.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
block_based_filter_block_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_table_builder.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_table_builder.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_table_factory.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_table_factory.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_table_iterator.cc	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_based_table_iterator.h	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_based_table_reader_impl.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
block_based_table_reader.cc	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_based_table_reader.h	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_builder.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_builder.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_prefetcher.cc	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_prefetcher.h	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_prefix_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_prefix_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_test.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
block_type.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block.cc	fix some spelling typos (#6464)	2020-02-28 14:14:03 -08:00
block.h	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
cachable_entry.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_footer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_footer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_hash_index_test.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
data_block_hash_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_hash_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_block_reader_common.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_block_reader_common.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_policy_internal.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_policy.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
flush_block_policy.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
flush_block_policy.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
full_filter_block_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
full_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
full_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
hash_index_reader.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
hash_index_reader.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
index_builder.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
index_builder.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
index_reader_common.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
index_reader_common.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
mock_block_based_table.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
parsed_full_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
parsed_full_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
partitioned_filter_block_test.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
partitioned_filter_block.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
partitioned_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
partitioned_index_iterator.cc	Fix regression bug in partitioned index reseek caused by #6531 (#6551)	2020-03-17 12:33:10 -07:00
partitioned_index_iterator.h	Fix compiler warning treated as error (#6547)	2020-03-17 09:59:28 -07:00
partitioned_index_reader.cc	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
partitioned_index_reader.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
reader_common.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
reader_common.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
uncompression_dict_reader.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
uncompression_dict_reader.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00