12f1137355
Summary: Introduces and uses a SystemClock class to RocksDB. This class contains the time-related functions of an Env and these functions can be redirected from the Env to the SystemClock. Many of the places that used an Env (Timer, PerfStepTimer, RepeatableThread, RateLimiter, WriteController) for time-related functions have been changed to use SystemClock instead. There are likely more places that can be changed, but this is a start to show what can/should be done. Over time it would be nice to migrate most (if not all) of the uses of the time functions from the Env to the SystemClock. There are several Env classes that implement these functions. Most of these have not been converted yet to SystemClock implementations; that will come in a subsequent PR. It would be good to unify many of the Mock Timer implementations, so that they behave similarly and be tested similarly (some override Sleep, some use a MockSleep, etc). Additionally, this change will allow new methods to be introduced to the SystemClock (like https://github.com/facebook/rocksdb/issues/7101 WaitFor) in a consistent manner across a smaller number of classes. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7858 Reviewed By: pdillinger Differential Revision: D26006406 Pulled By: mrambacher fbshipit-source-id: ed10a8abbdab7ff2e23d69d85bd25b3e7e899e90
151 lines
3.7 KiB
C++
151 lines
3.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
#include "db/arena_wrapped_db_iter.h"
|
|
#include "rocksdb/iterator.h"
|
|
#include "util/stop_watch.h"
|
|
#include "utilities/blob_db/blob_db_impl.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
class Statistics;
|
|
class SystemClock;
|
|
|
|
namespace blob_db {
|
|
|
|
using ROCKSDB_NAMESPACE::ManagedSnapshot;
|
|
|
|
class BlobDBIterator : public Iterator {
|
|
public:
|
|
BlobDBIterator(ManagedSnapshot* snapshot, ArenaWrappedDBIter* iter,
|
|
BlobDBImpl* blob_db, const std::shared_ptr<SystemClock>& clock,
|
|
Statistics* statistics)
|
|
: snapshot_(snapshot),
|
|
iter_(iter),
|
|
blob_db_(blob_db),
|
|
clock_(clock),
|
|
statistics_(statistics) {}
|
|
|
|
virtual ~BlobDBIterator() = default;
|
|
|
|
bool Valid() const override {
|
|
if (!iter_->Valid()) {
|
|
return false;
|
|
}
|
|
return status_.ok();
|
|
}
|
|
|
|
Status status() const override {
|
|
if (!iter_->status().ok()) {
|
|
return iter_->status();
|
|
}
|
|
return status_;
|
|
}
|
|
|
|
void SeekToFirst() override {
|
|
StopWatch seek_sw(clock_, statistics_, BLOB_DB_SEEK_MICROS);
|
|
RecordTick(statistics_, BLOB_DB_NUM_SEEK);
|
|
iter_->SeekToFirst();
|
|
while (UpdateBlobValue()) {
|
|
iter_->Next();
|
|
}
|
|
}
|
|
|
|
void SeekToLast() override {
|
|
StopWatch seek_sw(clock_, statistics_, BLOB_DB_SEEK_MICROS);
|
|
RecordTick(statistics_, BLOB_DB_NUM_SEEK);
|
|
iter_->SeekToLast();
|
|
while (UpdateBlobValue()) {
|
|
iter_->Prev();
|
|
}
|
|
}
|
|
|
|
void Seek(const Slice& target) override {
|
|
StopWatch seek_sw(clock_, statistics_, BLOB_DB_SEEK_MICROS);
|
|
RecordTick(statistics_, BLOB_DB_NUM_SEEK);
|
|
iter_->Seek(target);
|
|
while (UpdateBlobValue()) {
|
|
iter_->Next();
|
|
}
|
|
}
|
|
|
|
void SeekForPrev(const Slice& target) override {
|
|
StopWatch seek_sw(clock_, statistics_, BLOB_DB_SEEK_MICROS);
|
|
RecordTick(statistics_, BLOB_DB_NUM_SEEK);
|
|
iter_->SeekForPrev(target);
|
|
while (UpdateBlobValue()) {
|
|
iter_->Prev();
|
|
}
|
|
}
|
|
|
|
void Next() override {
|
|
assert(Valid());
|
|
StopWatch next_sw(clock_, statistics_, BLOB_DB_NEXT_MICROS);
|
|
RecordTick(statistics_, BLOB_DB_NUM_NEXT);
|
|
iter_->Next();
|
|
while (UpdateBlobValue()) {
|
|
iter_->Next();
|
|
}
|
|
}
|
|
|
|
void Prev() override {
|
|
assert(Valid());
|
|
StopWatch prev_sw(clock_, statistics_, BLOB_DB_PREV_MICROS);
|
|
RecordTick(statistics_, BLOB_DB_NUM_PREV);
|
|
iter_->Prev();
|
|
while (UpdateBlobValue()) {
|
|
iter_->Prev();
|
|
}
|
|
}
|
|
|
|
Slice key() const override {
|
|
assert(Valid());
|
|
return iter_->key();
|
|
}
|
|
|
|
Slice value() const override {
|
|
assert(Valid());
|
|
if (!iter_->IsBlob()) {
|
|
return iter_->value();
|
|
}
|
|
return value_;
|
|
}
|
|
|
|
// Iterator::Refresh() not supported.
|
|
|
|
private:
|
|
// Return true if caller should continue to next value.
|
|
bool UpdateBlobValue() {
|
|
value_.Reset();
|
|
status_ = Status::OK();
|
|
if (iter_->Valid() && iter_->status().ok() && iter_->IsBlob()) {
|
|
Status s = blob_db_->GetBlobValue(iter_->key(), iter_->value(), &value_);
|
|
if (s.IsNotFound()) {
|
|
return true;
|
|
} else {
|
|
if (!s.ok()) {
|
|
status_ = s;
|
|
}
|
|
return false;
|
|
}
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
std::unique_ptr<ManagedSnapshot> snapshot_;
|
|
std::unique_ptr<ArenaWrappedDBIter> iter_;
|
|
BlobDBImpl* blob_db_;
|
|
std::shared_ptr<SystemClock> clock_;
|
|
Statistics* statistics_;
|
|
Status status_;
|
|
PinnableSlice value_;
|
|
};
|
|
} // namespace blob_db
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
#endif // !ROCKSDB_LITE
|