7f08a8503f
Summary: IOSTATS_ADD_IF_POSITIVE() doesn't seem to a macro that aims to improve performance but does the opposite. The counter to add is almost always positive so the if is just a waste. Furthermore, adding to a thread local variable seemse to be much cheaper than an if condition if branch prediction has a possibility to be wrong. Remove the macro. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8984 Test Plan: See CI completes. Reviewed By: anand1976 Differential Revision: D31348163 fbshipit-source-id: 30af6d45e1aa8bbc09b2c046206cce6f67f4777a
57 lines
2.0 KiB
C++
57 lines
2.0 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#pragma once
|
|
#include "monitoring/perf_step_timer.h"
|
|
#include "rocksdb/iostats_context.h"
|
|
|
|
#if defined(ROCKSDB_SUPPORT_THREAD_LOCAL) && !defined(NIOSTATS_CONTEXT)
|
|
namespace ROCKSDB_NAMESPACE {
|
|
extern __thread IOStatsContext iostats_context;
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
// increment a specific counter by the specified value
|
|
#define IOSTATS_ADD(metric, value) (iostats_context.metric += value)
|
|
|
|
// reset a specific counter to zero
|
|
#define IOSTATS_RESET(metric) (iostats_context.metric = 0)
|
|
|
|
// reset all counters to zero
|
|
#define IOSTATS_RESET_ALL() (iostats_context.Reset())
|
|
|
|
#define IOSTATS_SET_THREAD_POOL_ID(value) \
|
|
(iostats_context.thread_pool_id = value)
|
|
|
|
#define IOSTATS_THREAD_POOL_ID() (iostats_context.thread_pool_id)
|
|
|
|
#define IOSTATS(metric) (iostats_context.metric)
|
|
|
|
// Declare and set start time of the timer
|
|
#define IOSTATS_TIMER_GUARD(metric) \
|
|
PerfStepTimer iostats_step_timer_##metric(&(iostats_context.metric)); \
|
|
iostats_step_timer_##metric.Start();
|
|
|
|
// Declare and set start time of the timer
|
|
#define IOSTATS_CPU_TIMER_GUARD(metric, clock) \
|
|
PerfStepTimer iostats_step_timer_##metric( \
|
|
&(iostats_context.metric), clock, true, \
|
|
PerfLevel::kEnableTimeAndCPUTimeExceptForMutex); \
|
|
iostats_step_timer_##metric.Start();
|
|
|
|
#else // ROCKSDB_SUPPORT_THREAD_LOCAL && !NIOSTATS_CONTEXT
|
|
|
|
#define IOSTATS_ADD(metric, value)
|
|
#define IOSTATS_ADD_IF_POSITIVE(metric, value)
|
|
#define IOSTATS_RESET(metric)
|
|
#define IOSTATS_RESET_ALL()
|
|
#define IOSTATS_SET_THREAD_POOL_ID(value)
|
|
#define IOSTATS_THREAD_POOL_ID()
|
|
#define IOSTATS(metric) 0
|
|
|
|
#define IOSTATS_TIMER_GUARD(metric)
|
|
#define IOSTATS_CPU_TIMER_GUARD(metric, clock) static_cast<void>(clock)
|
|
|
|
#endif // ROCKSDB_SUPPORT_THREAD_LOCAL && !NIOSTATS_CONTEXT
|