rocksdb/build_tools
Peter Dillinger 35af0433cf Fix crash test with backup as read-only DB (#8161)
Summary:
Forgot to re-test crash test after adding read-only filesystem
enforcement to https://github.com/facebook/rocksdb/issues/8142. The problem is ReadOnlyFileSystem would reject
CreateDirIfMissing whenever DBOptions::create_if_missing=true. The fix
that is better for users is to allow CreateDirIfMissing in
ReadOnlyFileSystem if the directory exists, so that they don't cause a
failure on using create_if_missing with opening backups as read-only
DBs. Added this option test to the unit test (in addition to being in the
crash test).

Also fixed a couple of lints.

And some better messaging from 'make format' so that when you run it
with uncommitted changes, it's clear that it's only checking the
uncommitted changes.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8161

Test Plan: local blackbox_crash_test with amplified backup_one_in

Reviewed By: ajkr

Differential Revision: D27614409

Pulled By: pdillinger

fbshipit-source-id: 63ccb626c7e34c200d61c6bca2a8f60da9015179
2021-04-06 23:31:51 -07:00
..
amalgamate.py Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
build_detect_platform Pass PLATFORM_FLAGS in build_detect_platform (#8111) 2021-03-31 07:40:46 -07:00
dependencies_4.8.1.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
dependencies_platform007.sh PosixRandomAccessFile::MultiRead() to use I/O uring if supported (#5881) 2019-12-07 20:55:52 -08:00
dependencies_platform009.sh Still use platform007 for gcc (#7253) 2020-08-13 14:49:34 -07:00
dependencies.sh Update dependencies (#5777) 2019-09-16 20:44:47 -07:00
dockerbuild.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
error_filter.py Enable txn in crash tests (#6155) 2019-12-11 16:01:55 -08:00
fb_compile_mongo.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
fbcode_config4.8.1.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
fbcode_config_platform007.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
fbcode_config_platform009.sh Upgrade tool chain (#7251) 2020-08-12 19:30:00 -07:00
fbcode_config.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
format-diff.sh Fix crash test with backup as read-only DB (#8161) 2021-04-06 23:31:51 -07:00
gnu_parallel fix some spelling typos (#6464) 2020-02-28 14:14:03 -08:00
make_package.sh Use standard variables for installing/uninstalling with make (#7187) 2020-08-28 14:47:31 -07:00
precommit_checker.py build_tools/precommit_checker.py: don't hard-code a platform-afflicted python path (#6124) 2019-12-05 11:49:17 -08:00
regression_build_test.sh Don't download from (unreliable) maven.org (#6348) 2020-01-30 11:02:08 -08:00
rocksdb-lego-determinator Add stress crash test with timestamp to lego determinator (#8104) 2021-03-24 17:58:31 -07:00
run_ci_db_test.ps1 Extract test cases correctly in run_ci_db_test.ps1 script (#7989) 2021-02-23 14:25:42 -08:00
setup_centos7.sh Adding new build script for CentOS 7 (#6617) 2020-04-06 16:20:27 -07:00
update_dependencies.sh PosixRandomAccessFile::MultiRead() to use I/O uring if supported (#5881) 2019-12-07 20:55:52 -08:00
version.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00