e56b2c5a31
Summary: The fcntl call cannot detect lock conflicts when invoked multiple times from the same thread. Use a static lockedFile Set to record the paths that are locked. A lockfile request checks to see if htis filename already exists in lockedFiles, if so, then it triggers an error. Otherwise, it inserts the filename in the lockedFiles Set. A unlock file request verifies that the filename is in the lockedFiles set and removes it from lockedFiles set. Test Plan: unit test attached Reviewers: heyongqiang Reviewed By: heyongqiang Differential Revision: https://reviews.facebook.net/D4755
58 lines
1.1 KiB
C++
58 lines
1.1 KiB
C++
// Copyright (c) 2012 Facebook. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "leveldb/status.h"
|
|
#include "leveldb/env.h"
|
|
|
|
#include <vector>
|
|
#include "util/coding.h"
|
|
#include "util/testharness.h"
|
|
|
|
namespace leveldb {
|
|
|
|
class LockTest {
|
|
public:
|
|
static LockTest* current_;
|
|
std::string file_;
|
|
leveldb::Env* env_;
|
|
|
|
LockTest() : file_(test::TmpDir() + "/db_testlock_file"),
|
|
env_(leveldb::Env::Default()) {
|
|
current_ = this;
|
|
}
|
|
|
|
~LockTest() {
|
|
}
|
|
|
|
Status LockFile(FileLock** db_lock) {
|
|
return env_->LockFile(file_, db_lock);
|
|
}
|
|
|
|
Status UnlockFile(FileLock* db_lock) {
|
|
return env_->UnlockFile(db_lock);
|
|
}
|
|
};
|
|
LockTest* LockTest::current_;
|
|
|
|
TEST(LockTest, LockBySameThread) {
|
|
FileLock* lock1;
|
|
FileLock* lock2;
|
|
|
|
// acquire a lock on a file
|
|
ASSERT_OK(LockFile(&lock1));
|
|
|
|
// re-acquire the lock on the same file. This should fail.
|
|
ASSERT_TRUE(LockFile(&lock2).IsIOError());
|
|
|
|
// release the lock
|
|
ASSERT_OK(UnlockFile(lock1));
|
|
|
|
}
|
|
|
|
} // namespace leveldb
|
|
|
|
int main(int argc, char** argv) {
|
|
return leveldb::test::RunAllTests();
|
|
}
|