andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
A library that provides an embeddable, persistent key-value store for fast storage.
5,522 Commits 152 Branches 236 Tags 271 MiB
C++ 82.1%
Java 10.3%
C 2.5%
Python 1.7%
Perl 1.1%
Other 2.1%
1168cb810a
Go to file
sdong 1168cb810a Fix a bug that may cause a deleted row to appear again 
Summary:
The previous fix of reappearing of a deleted row 0ce258f9b3 missed a corner case, which can be reproduced using test CompactionPickerTest.OverlappingUserKeys7. Consider such an example:

input level file: 1[B E] 2[F H]
output level file: 3[A C] 4[D I] 5[I K]

First file 2 is picked, which overlaps to file 4. 4 expands to 5. Now the all range is [D K] with 2 output level files. When we try to expand that, [D K] overlaps with file 1 and 2 in the input level, and 1 and 2 overlaps with 3 and 4 in the output level. So we end up with picking 3 and 4 in the output level. Without expanding, it also has 2 files, so we determine the output level doesn't change, although they are the different two files.

The fix is to expand the output level files after we picked 3 and 4. In that case, there will be three output level files so we will abort the expanding.

I also added two unit tests related to marked_for_compaction and being_compacted. They have been passing though.

Test Plan: Run the new unit test, as well as all other tests.

Reviewers: andrewkr, IslamAbdelRahman

Reviewed By: IslamAbdelRahman

Subscribers: yoshinorim, leveldb, andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D65373
2016-10-24 09:49:07 -07:00
arcanist_util Fix arcanist 2016-10-12 20:11:30 -07:00
build_tools Support ZSTD with finalized format 2016-09-06 12:22:16 -07:00
cmake/modules cmake support for linux and osx (#1358) 2016-09-28 11:53:15 -07:00
coverage Fix coverage script 2014-11-03 14:53:00 -08:00
db Fix a bug that may cause a deleted row to appear again 2016-10-24 09:49:07 -07:00
docs Editorial change to README.md 2016-10-12 20:24:50 -07:00
examples Fix typo (#903) 2016-09-14 14:12:31 -07:00
hdfs Fix bug in UnScSigned-off-by: xh931076284 <931076284@qq.com> (#1336) 2016-09-14 10:17:34 -07:00
include/rocksdb Make IsDeadlockDetect() virtual member of Transaction 2016-10-21 14:47:59 -07:00
java Support IngestExternalFile (remove AddFile restrictions) 2016-10-20 17:05:32 -07:00
memtable Add SeekForPrev() to Iterator 2016-09-27 18:20:57 -07:00
port Fix integer overflow in GetL0ThresholdSpeedupCompaction (#1378) 2016-10-23 18:43:29 -07:00
table Change ioptions to store user_comparator, fix bug 2016-10-21 11:31:42 -07:00
third-party Fix clang analyzer errors 2016-07-08 17:50:51 -07:00
tools Fix a bug that mistakenly disable regression_test.sh to update commit (#1415) 2016-10-21 17:26:24 -07:00
util Change ioptions to store user_comparator, fix bug 2016-10-21 11:31:42 -07:00
utilities Make IsDeadlockDetect() virtual member of Transaction 2016-10-21 14:47:59 -07:00
.arcconfig Integrate Jenkins with Phabricator 2015-04-07 11:56:29 -07:00
.clang-format A script that automatically reformat affected lines 2014-01-14 12:21:24 -08:00
.gitignore Experiments on column-aware encodings 2016-08-01 14:50:19 -07:00
.travis.yml Fix travis 2016-08-31 00:10:49 -07:00
appveyor.yml fix vs generator (#1269) 2016-08-10 09:08:13 -07:00
AUTHORS Add AUTHORS file. Fix #203 2014-09-29 10:52:18 -07:00
CMakeLists.txt Support IngestExternalFile (remove AddFile restrictions) 2016-10-20 17:05:32 -07:00
CONTRIBUTING.md facebook accounts are not required for CLA signers 2014-07-08 05:57:54 -04:00
DEFAULT_OPTIONS_HISTORY.md Release RocksDB 4.8.0 2016-05-02 14:38:04 -07:00
DUMP_FORMAT.md First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
HISTORY.md Bump RocksDB version to 4.13 (#1405) 2016-10-18 15:39:10 -07:00
INSTALL.md Simple changes to support builds for ppc64[le] consistent with X86 2016-01-19 09:08:19 -06:00
LANGUAGE-BINDINGS.md Update LANGUAGE-BINDINGS.md 2016-07-15 13:09:30 +02:00
LICENSE Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
Makefile Passing DISABLE_JEMALLOC=1 to valgrind_check if run locally 2016-10-21 14:57:44 -07:00
PATENTS Update Patent Grant. 2015-04-13 10:33:43 +01:00
README.md Appveyor badge to show master branch 2016-07-26 13:54:08 -07:00
ROCKSDB_LITE.md Optimistic Transactions 2015-05-29 14:36:35 -07:00
src.mk Support IngestExternalFile (remove AddFile restrictions) 2016-10-20 17:05:32 -07:00
thirdparty.inc Introduce XPRESS compresssion on Windows. (#1081) 2016-04-19 22:54:24 -07:00
USERS.md Adding Dgraph to list of Users (#1291) 2016-09-12 17:33:44 -07:00
Vagrantfile RocksDB on FreeBSD support 2015-02-26 15:19:17 -08:00
WINDOWS_PORT.md Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00

README.md

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Build Status Build status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/