5ce246c716
Summary: The patch adds support for exposing the start of the expiration range for TTL blob files through the `GetLiveFilesMetaData` API. This can be used for monitoring purposes, i.e. to make sure TTL blob files are deleted in a timely manner. The patch also fixes a couple of uninitialized variable issues. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7365 Test Plan: `make check` Reviewed By: pdillinger Differential Revision: D23605465 Pulled By: ltamasi fbshipit-source-id: 97a9612bf5f4b058423debdd3f28f576bb23a70f
114 lines
3.6 KiB
C++
114 lines
3.6 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
#include "file/filename.h"
|
|
#include "logging/logging.h"
|
|
#include "util/cast_util.h"
|
|
#include "util/mutexlock.h"
|
|
#include "utilities/blob_db/blob_db_impl.h"
|
|
|
|
// BlobDBImpl methods to get snapshot of files, e.g. for replication.
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
namespace blob_db {
|
|
|
|
Status BlobDBImpl::DisableFileDeletions() {
|
|
// Disable base DB file deletions.
|
|
Status s = db_impl_->DisableFileDeletions();
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
|
|
int count = 0;
|
|
{
|
|
// Hold delete_file_mutex_ to make sure no DeleteObsoleteFiles job
|
|
// is running.
|
|
MutexLock l(&delete_file_mutex_);
|
|
count = ++disable_file_deletions_;
|
|
}
|
|
|
|
ROCKS_LOG_INFO(db_options_.info_log,
|
|
"Disabled blob file deletions. count: %d", count);
|
|
return Status::OK();
|
|
}
|
|
|
|
Status BlobDBImpl::EnableFileDeletions(bool force) {
|
|
// Enable base DB file deletions.
|
|
Status s = db_impl_->EnableFileDeletions(force);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
|
|
int count = 0;
|
|
{
|
|
MutexLock l(&delete_file_mutex_);
|
|
if (force) {
|
|
disable_file_deletions_ = 0;
|
|
} else if (disable_file_deletions_ > 0) {
|
|
count = --disable_file_deletions_;
|
|
}
|
|
assert(count >= 0);
|
|
}
|
|
|
|
ROCKS_LOG_INFO(db_options_.info_log, "Enabled blob file deletions. count: %d",
|
|
count);
|
|
// Consider trigger DeleteobsoleteFiles once after re-enabled, if we are to
|
|
// make DeleteobsoleteFiles re-run interval configuration.
|
|
return Status::OK();
|
|
}
|
|
|
|
Status BlobDBImpl::GetLiveFiles(std::vector<std::string>& ret,
|
|
uint64_t* manifest_file_size,
|
|
bool flush_memtable) {
|
|
if (!bdb_options_.path_relative) {
|
|
return Status::NotSupported(
|
|
"Not able to get relative blob file path from absolute blob_dir.");
|
|
}
|
|
// Hold a lock in the beginning to avoid updates to base DB during the call
|
|
ReadLock rl(&mutex_);
|
|
Status s = db_->GetLiveFiles(ret, manifest_file_size, flush_memtable);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
ret.reserve(ret.size() + blob_files_.size());
|
|
for (auto bfile_pair : blob_files_) {
|
|
auto blob_file = bfile_pair.second;
|
|
// Path should be relative to db_name, but begin with slash.
|
|
ret.emplace_back(
|
|
BlobFileName("", bdb_options_.blob_dir, blob_file->BlobFileNumber()));
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
void BlobDBImpl::GetLiveFilesMetaData(std::vector<LiveFileMetaData>* metadata) {
|
|
// Path should be relative to db_name.
|
|
assert(bdb_options_.path_relative);
|
|
// Hold a lock in the beginning to avoid updates to base DB during the call
|
|
ReadLock rl(&mutex_);
|
|
db_->GetLiveFilesMetaData(metadata);
|
|
for (auto bfile_pair : blob_files_) {
|
|
auto blob_file = bfile_pair.second;
|
|
LiveFileMetaData filemetadata;
|
|
filemetadata.size = static_cast<size_t>(blob_file->GetFileSize());
|
|
const uint64_t file_number = blob_file->BlobFileNumber();
|
|
// Path should be relative to db_name, but begin with slash.
|
|
filemetadata.name = BlobFileName("", bdb_options_.blob_dir, file_number);
|
|
filemetadata.file_number = file_number;
|
|
if (blob_file->HasTTL()) {
|
|
filemetadata.oldest_ancester_time = blob_file->GetExpirationRange().first;
|
|
}
|
|
auto cfh =
|
|
static_cast_with_check<ColumnFamilyHandleImpl>(DefaultColumnFamily());
|
|
filemetadata.column_family_name = cfh->GetName();
|
|
metadata->emplace_back(filemetadata);
|
|
}
|
|
}
|
|
|
|
} // namespace blob_db
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
#endif // !ROCKSDB_LITE
|