andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/util
History
Hui Xiao a64c8ca7a8 Sanitize negative request bytes in GenericRateLimiter::Request and clarify API (#9112) 
Summary:
Context:
Surprisingly, there isn't any sanitization against negative `int64_t bytes` in `GenericRateLimiter::Request(int64_t bytes, const Env::IOPriority pri, Statistics* stats)`. A negative `bytes` can be passed in and incorrectly increases `available_bytes_` by subtracting the negative `bytes` from `available_bytes_`, such as  [here](https://github.com/facebook/rocksdb/blob/main/util/rate_limiter.cc#L138) and [here](https://github.com/facebook/rocksdb/blob/main/util/rate_limiter.cc#L283), which are incorrect behaviors.
- Sanitized negative request bytes by rounding it up to 0
- Added notes to public and internal API

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9112

Test Plan: - Rely on existing tests

Reviewed By: ajkr

Differential Revision: D32085364

Pulled By: hx235

fbshipit-source-id: b1b6066b2dd5ffc7bcbfb07069ca65a33578251b
2021-11-04 10:11:53 -07:00
..
aligned_buffer.h
Fix wrong comments about function TruncateToPageBoundary. (#6975)
2020-10-07 12:34:34 -07:00
autovector_test.cc
Replace most typedef with using= (#8751)
2021-09-07 11:31:59 -07:00
autovector.h
Replace most typedef with using= (#8751)
2021-09-07 11:31:59 -07:00
bloom_impl.h
Ribbon: InterleavedSolutionStorage (#7598)
2020-11-03 12:46:36 -08:00
bloom_test.cc
Add support for building on s390x platform (#8962)
2021-10-22 10:13:15 -07:00
build_version.cc.in
Make builds reproducible (#7866)
2021-01-28 17:42:16 -08:00
cast_util.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
channel.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
coding_lean.h
Refine Ribbon configuration, improve testing, add Homogeneous (#7879)
2021-02-26 08:50:42 -08:00
coding_test.cc
Fix potential overflow of unsigned type in for loop (#6902)
2020-06-02 15:05:07 -07:00
coding.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
coding.h
Refine Ribbon configuration, improve testing, add Homogeneous (#7879)
2021-02-26 08:50:42 -08:00
compaction_job_stats_impl.cc
Update compaction statistics to include the amount of data read from blob files (#8022)
2021-03-04 00:43:48 -08:00
comparator.cc
Add customizable_util.h to the public API (#8301)
2021-06-29 09:08:57 -07:00
compression_context_cache.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
compression_context_cache.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
compression.h
Add support for building on s390x platform (#8962)
2021-10-22 10:13:15 -07:00
concurrent_task_limiter_impl.cc
Remove TaskLimiterToken::ReleaseOnce for fix (#8567)
2021-07-21 17:37:53 -07:00
concurrent_task_limiter_impl.h
Remove TaskLimiterToken::ReleaseOnce for fix (#8567)
2021-07-21 17:37:53 -07:00
core_local.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
crc32c_arm64.cc
Mac M1 crc32 intrinsics ARM64 check support proposal (#7893)
2021-03-10 09:05:56 -08:00
crc32c_arm64.h
Fix compilation on Apple Silicon (#7714)
2020-12-04 15:22:33 -08:00
crc32c_ppc_asm.S
Fix Compilation on ppc64le using Clang 11 (#7713)
2020-12-01 11:21:44 -08:00
crc32c_ppc_constants.h
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
crc32c_ppc.c
Fix Compilation on ppc64le using Clang 11 (#7713)
2020-12-01 11:21:44 -08:00
crc32c_ppc.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
crc32c_test.cc
Implementation of Crc32c combine function (#8305)
2021-06-16 18:30:34 -07:00
crc32c.cc
Replace most typedef with using= (#8751)
2021-09-07 11:31:59 -07:00
crc32c.h
Implementation of Crc32c combine function (#8305)
2021-06-16 18:30:34 -07:00
defer_test.cc
Fix insecure internal API for GetImpl (#8590)
2021-07-29 17:23:01 -07:00
defer.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
duplicate_detector.h
Cleanup includes in dbformat.h (#8930)
2021-09-29 04:04:40 -07:00
dynamic_bloom_test.cc
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
dynamic_bloom.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
dynamic_bloom.h
Genericize and clean up FastRange (#7436)
2020-09-28 11:35:00 -07:00
fastrange.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
file_checksum_helper.cc
Make WalFilter, SstPartitionerFactory, FileChecksumGenFactory, and TableProperties Customizable (#8638)
2021-09-28 05:32:02 -07:00
file_checksum_helper.h
Make WalFilter, SstPartitionerFactory, FileChecksumGenFactory, and TableProperties Customizable (#8638)
2021-09-28 05:32:02 -07:00
file_reader_writer_test.cc
Make SystemClock into a Customizable Class (#8636)
2021-09-21 09:23:48 -07:00
filelock_test.cc
Fix MSVC-related build issues (#7439)
2020-10-01 09:23:04 -07:00
filter_bench.cc
Rename variables in ImmutableCFOptions to avoid conflicts with ImmutableDBOptions (#8227)
2021-04-26 12:43:45 -07:00
gflags_compat.h
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
2020-10-27 10:33:09 -07:00
hash128.h
Upgrade xxhash, add Hash128 (#8634)
2021-08-20 18:41:51 -07:00
hash_map.h
Change HashMap::Insert()'s value to a const reference (#6567)
2020-03-20 14:59:54 -07:00
hash_test.cc
Experimental support for SST unique IDs (#8990)
2021-10-18 23:32:01 -07:00
hash.cc
Experimental support for SST unique IDs (#8990)
2021-10-18 23:32:01 -07:00
hash.h
Experimental support for SST unique IDs (#8990)
2021-10-18 23:32:01 -07:00
heap_test.cc
Revert "Update googletest from 1.8.1 to 1.10.0 (#6808)" (#6923)
2020-06-03 15:55:03 -07:00
heap.h
Avoid self-move-assign in pop operation of binary heap. (#7942)
2021-02-19 13:47:25 -08:00
kv_map.h
Replace most typedef with using= (#8751)
2021-09-07 11:31:59 -07:00
log_write_bench.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
math128.h
Refine Ribbon configuration, improve testing, add Homogeneous (#7879)
2021-02-26 08:50:42 -08:00
math.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
murmurhash.cc
C++20 compatibility (#6697)
2020-04-20 13:24:25 -07:00
murmurhash.h
Replace most typedef with using= (#8751)
2021-09-07 11:31:59 -07:00
mutexlock.h
Prevents Table Cache to open same files more times (#6707)
2020-04-21 13:16:31 -07:00
ppc-opcode.h
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
random_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
random.cc
Add De/Serialization for CompactionInput/Result (#8247)
2021-05-12 12:36:43 -07:00
random.h
Experimental support for SST unique IDs (#8990)
2021-10-18 23:32:01 -07:00
rate_limiter_test.cc
Return Status::NotSupported() in RateLimiter::GetTotalPendingRequests default impl (#8950)
2021-09-22 19:36:06 -07:00
rate_limiter.cc
Sanitize negative request bytes in GenericRateLimiter::Request and clarify API (#9112)
2021-11-04 10:11:53 -07:00
rate_limiter.h
Sanitize negative request bytes in GenericRateLimiter::Request and clarify API (#9112)
2021-11-04 10:11:53 -07:00
regex.cc
Improve support for using regexes (#8740)
2021-09-07 13:05:23 -07:00
repeatable_thread_test.cc
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
repeatable_thread.h
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
ribbon_alg.h
Refine Ribbon configuration, improve testing, add Homogeneous (#7879)
2021-02-26 08:50:42 -08:00
ribbon_config.cc
Refine Ribbon configuration, improve testing, add Homogeneous (#7879)
2021-02-26 08:50:42 -08:00
ribbon_config.h
Refine Ribbon configuration, improve testing, add Homogeneous (#7879)
2021-02-26 08:50:42 -08:00
ribbon_impl.h
Upgrade xxhash, add Hash128 (#8634)
2021-08-20 18:41:51 -07:00
ribbon_test.cc
Upgrade xxhash, add Hash128 (#8634)
2021-08-20 18:41:51 -07:00
set_comparator.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
slice_test.cc
Improve support for using regexes (#8740)
2021-09-07 13:05:23 -07:00
slice_transform_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
slice.cc
Allow unregistered options to be ignored in DBOptions from files (#9045)
2021-10-19 10:43:04 -07:00
status.cc
Add remote compaction public API (#8300)
2021-05-19 21:41:31 -07:00
stderr_logger.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
stop_watch.h
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
string_util.cc
Remove some unneeded code (#8736)
2021-09-01 14:28:58 -07:00
string_util.h
Experimental support for SST unique IDs (#8990)
2021-10-18 23:32:01 -07:00
thread_guard.h
Introduce a ThreadGuard class and use it in ExternalSSTFileTest.PickedLevelBug (#8112)
2021-03-25 22:08:58 -07:00
thread_list_test.cc
fix thread status synchronization in thread_list_test (#7825)
2021-01-04 10:46:24 -08:00
thread_local_test.cc
Add StartThread type checking wrapper (#8303)
2021-05-19 16:51:13 -07:00
thread_local.cc
Fix typo in ThreadData comment (#7131)
2020-07-15 09:23:23 -07:00
thread_local.h
Replace most typedef with using= (#8751)
2021-09-07 11:31:59 -07:00
thread_operation.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
threadpool_imp.cc
Prevent joining detached thread in ThreadPoolImpl (#8635)
2021-08-06 19:06:02 -07:00
threadpool_imp.h
Make it able to lower cpu priority to specific level in threadpool (#6969)
2020-06-13 13:25:20 -07:00
timer_queue_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
timer_queue.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
timer_test.cc
Skip directory fsync for filesystem btrfs (#8903)
2021-11-03 12:21:27 -07:00
timer.h
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
user_comparator_wrapper.h
Enable backward iterator for keys with user-defined timestamp (#8035)
2021-03-10 11:15:46 -08:00
vector_iterator.h
Cleanup multiple implementations of VectorIterator (#8901)
2021-10-06 07:48:31 -07:00
work_queue_test.cc
Add pipelined & parallel compression optimization (#6262)
2020-04-01 16:40:18 -07:00
work_queue.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00
xxhash.cc
Upgrade xxhash, add Hash128 (#8634)
2021-08-20 18:41:51 -07:00
xxhash.h
Upgrade xxhash, add Hash128 (#8634)
2021-08-20 18:41:51 -07:00
xxph3.h
Fix and detect headers with missing dependencies (#8893)
2021-09-10 10:00:26 -07:00