3dff28cf9b
Summary: For performance purposes, the lower level routines were changed to use a SystemClock* instead of a std::shared_ptr<SystemClock>. The shared ptr has some performance degradation on certain hardware classes. For most of the system, there is no risk of the pointer being deleted/invalid because the shared_ptr will be stored elsewhere. For example, the ImmutableDBOptions stores the Env which has a std::shared_ptr<SystemClock> in it. The SystemClock* within the ImmutableDBOptions is essentially a "short cut" to gain access to this constant resource. There were a few classes (PeriodicWorkScheduler?) where the "short cut" property did not hold. In those cases, the shared pointer was preserved. Using db_bench readrandom perf_level=3 on my EC2 box, this change performed as well or better than 6.17: 6.17: readrandom : 28.046 micros/op 854902 ops/sec; 61.3 MB/s (355999 of 355999 found) 6.18: readrandom : 32.615 micros/op 735306 ops/sec; 52.7 MB/s (290999 of 290999 found) PR: readrandom : 27.500 micros/op 871909 ops/sec; 62.5 MB/s (367999 of 367999 found) (Note that the times for 6.18 are prior to revert of the SystemClock). Pull Request resolved: https://github.com/facebook/rocksdb/pull/8033 Reviewed By: pdillinger Differential Revision: D27014563 Pulled By: mrambacher fbshipit-source-id: ad0459eba03182e454391b5926bf5cdd45657b67
96 lines
3.3 KiB
C++
96 lines
3.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
#pragma once
|
|
|
|
#include <cinttypes>
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "rocksdb/compression_type.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class VersionSet;
|
|
class FileSystem;
|
|
class SystemClock;
|
|
struct ImmutableCFOptions;
|
|
struct MutableCFOptions;
|
|
struct FileOptions;
|
|
class BlobFileAddition;
|
|
class Status;
|
|
class Slice;
|
|
class BlobLogWriter;
|
|
class IOTracer;
|
|
|
|
class BlobFileBuilder {
|
|
public:
|
|
BlobFileBuilder(VersionSet* versions, FileSystem* fs,
|
|
const ImmutableCFOptions* immutable_cf_options,
|
|
const MutableCFOptions* mutable_cf_options,
|
|
const FileOptions* file_options, int job_id,
|
|
uint32_t column_family_id,
|
|
const std::string& column_family_name,
|
|
Env::IOPriority io_priority,
|
|
Env::WriteLifeTimeHint write_hint,
|
|
const std::shared_ptr<IOTracer>& io_tracer,
|
|
std::vector<std::string>* blob_file_paths,
|
|
std::vector<BlobFileAddition>* blob_file_additions);
|
|
|
|
BlobFileBuilder(std::function<uint64_t()> file_number_generator,
|
|
FileSystem* fs,
|
|
const ImmutableCFOptions* immutable_cf_options,
|
|
const MutableCFOptions* mutable_cf_options,
|
|
const FileOptions* file_options, int job_id,
|
|
uint32_t column_family_id,
|
|
const std::string& column_family_name,
|
|
Env::IOPriority io_priority,
|
|
Env::WriteLifeTimeHint write_hint,
|
|
const std::shared_ptr<IOTracer>& io_tracer,
|
|
std::vector<std::string>* blob_file_paths,
|
|
std::vector<BlobFileAddition>* blob_file_additions);
|
|
|
|
BlobFileBuilder(const BlobFileBuilder&) = delete;
|
|
BlobFileBuilder& operator=(const BlobFileBuilder&) = delete;
|
|
|
|
~BlobFileBuilder();
|
|
|
|
Status Add(const Slice& key, const Slice& value, std::string* blob_index);
|
|
Status Finish();
|
|
|
|
private:
|
|
bool IsBlobFileOpen() const;
|
|
Status OpenBlobFileIfNeeded();
|
|
Status CompressBlobIfNeeded(Slice* blob, std::string* compressed_blob) const;
|
|
Status WriteBlobToFile(const Slice& key, const Slice& blob,
|
|
uint64_t* blob_file_number, uint64_t* blob_offset);
|
|
Status CloseBlobFile();
|
|
Status CloseBlobFileIfNeeded();
|
|
|
|
std::function<uint64_t()> file_number_generator_;
|
|
FileSystem* fs_;
|
|
const ImmutableCFOptions* immutable_cf_options_;
|
|
uint64_t min_blob_size_;
|
|
uint64_t blob_file_size_;
|
|
CompressionType blob_compression_type_;
|
|
const FileOptions* file_options_;
|
|
int job_id_;
|
|
uint32_t column_family_id_;
|
|
std::string column_family_name_;
|
|
Env::IOPriority io_priority_;
|
|
Env::WriteLifeTimeHint write_hint_;
|
|
std::shared_ptr<IOTracer> io_tracer_;
|
|
std::vector<std::string>* blob_file_paths_;
|
|
std::vector<BlobFileAddition>* blob_file_additions_;
|
|
std::unique_ptr<BlobLogWriter> writer_;
|
|
uint64_t blob_count_;
|
|
uint64_t blob_bytes_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|