9aad24da55
Summary: This is a "real" fix for the issue worked around in https://github.com/facebook/rocksdb/issues/7294. To get DB checksum info for live files, we now read the manifest file that will become part of the checkpoint/backup. This requires a little extra handling in taking a custom checkpoint, including only reading the manifest file up to the size prescribed by the checkpoint. This moves GetFileChecksumsFromManifest from backup code to file_checksum_helper.{h,cc} and removes apparently unnecessary checking related to column families. Updated HISTORY.md and warned potential future users of DB::GetLiveFilesChecksumInfo() Pull Request resolved: https://github.com/facebook/rocksdb/pull/7309 Test Plan: updated unit test, before and after Reviewed By: ajkr Differential Revision: D23311994 Pulled By: pdillinger fbshipit-source-id: 741e30a2dc1830e8208f7648fcc8c5f000d4e2d5
155 lines
5.0 KiB
C++
155 lines
5.0 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "util/file_checksum_helper.h"
|
|
|
|
#include <unordered_set>
|
|
|
|
#include "db/log_reader.h"
|
|
#include "db/version_edit.h"
|
|
#include "file/sequence_file_reader.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
void FileChecksumListImpl::reset() { checksum_map_.clear(); }
|
|
|
|
size_t FileChecksumListImpl::size() const { return checksum_map_.size(); }
|
|
|
|
Status FileChecksumListImpl::GetAllFileChecksums(
|
|
std::vector<uint64_t>* file_numbers, std::vector<std::string>* checksums,
|
|
std::vector<std::string>* checksum_func_names) {
|
|
if (file_numbers == nullptr || checksums == nullptr ||
|
|
checksum_func_names == nullptr) {
|
|
return Status::InvalidArgument("Pointer has not been initiated");
|
|
}
|
|
|
|
for (auto i : checksum_map_) {
|
|
file_numbers->push_back(i.first);
|
|
checksums->push_back(i.second.first);
|
|
checksum_func_names->push_back(i.second.second);
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
Status FileChecksumListImpl::SearchOneFileChecksum(
|
|
uint64_t file_number, std::string* checksum,
|
|
std::string* checksum_func_name) {
|
|
if (checksum == nullptr || checksum_func_name == nullptr) {
|
|
return Status::InvalidArgument("Pointer has not been initiated");
|
|
}
|
|
|
|
auto it = checksum_map_.find(file_number);
|
|
if (it == checksum_map_.end()) {
|
|
return Status::NotFound();
|
|
} else {
|
|
*checksum = it->second.first;
|
|
*checksum_func_name = it->second.second;
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
Status FileChecksumListImpl::InsertOneFileChecksum(
|
|
uint64_t file_number, const std::string& checksum,
|
|
const std::string& checksum_func_name) {
|
|
auto it = checksum_map_.find(file_number);
|
|
if (it == checksum_map_.end()) {
|
|
checksum_map_.insert(std::make_pair(
|
|
file_number, std::make_pair(checksum, checksum_func_name)));
|
|
} else {
|
|
it->second.first = checksum;
|
|
it->second.second = checksum_func_name;
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
Status FileChecksumListImpl::RemoveOneFileChecksum(uint64_t file_number) {
|
|
auto it = checksum_map_.find(file_number);
|
|
if (it == checksum_map_.end()) {
|
|
return Status::NotFound();
|
|
} else {
|
|
checksum_map_.erase(it);
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
FileChecksumList* NewFileChecksumList() {
|
|
FileChecksumListImpl* checksum_list = new FileChecksumListImpl();
|
|
return checksum_list;
|
|
}
|
|
|
|
std::shared_ptr<FileChecksumGenFactory> GetFileChecksumGenCrc32cFactory() {
|
|
static std::shared_ptr<FileChecksumGenFactory> default_crc32c_gen_factory(
|
|
new FileChecksumGenCrc32cFactory());
|
|
return default_crc32c_gen_factory;
|
|
}
|
|
|
|
Status GetFileChecksumsFromManifest(Env* src_env, const std::string& abs_path,
|
|
uint64_t manifest_file_size,
|
|
FileChecksumList* checksum_list) {
|
|
if (checksum_list == nullptr) {
|
|
return Status::InvalidArgument("checksum_list is nullptr");
|
|
}
|
|
|
|
checksum_list->reset();
|
|
Status s;
|
|
|
|
std::unique_ptr<SequentialFileReader> file_reader;
|
|
{
|
|
std::unique_ptr<FSSequentialFile> file;
|
|
const std::shared_ptr<FileSystem>& fs = src_env->GetFileSystem();
|
|
s = fs->NewSequentialFile(abs_path,
|
|
fs->OptimizeForManifestRead(FileOptions()), &file,
|
|
nullptr /* dbg */);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
file_reader.reset(new SequentialFileReader(std::move(file), abs_path));
|
|
}
|
|
|
|
struct LogReporter : public log::Reader::Reporter {
|
|
Status* status_ptr;
|
|
virtual void Corruption(size_t /*bytes*/, const Status& st) override {
|
|
if (status_ptr->ok()) {
|
|
*status_ptr = st;
|
|
}
|
|
}
|
|
} reporter;
|
|
reporter.status_ptr = &s;
|
|
log::Reader reader(nullptr, std::move(file_reader), &reporter,
|
|
true /* checksum */, 0 /* log_number */);
|
|
Slice record;
|
|
std::string scratch;
|
|
while (reader.LastRecordEnd() < manifest_file_size &&
|
|
reader.ReadRecord(&record, &scratch) && s.ok()) {
|
|
VersionEdit edit;
|
|
s = edit.DecodeFrom(record);
|
|
if (!s.ok()) {
|
|
break;
|
|
}
|
|
|
|
// Remove the deleted files from the checksum_list
|
|
for (const auto& deleted_file : edit.GetDeletedFiles()) {
|
|
checksum_list->RemoveOneFileChecksum(deleted_file.second);
|
|
}
|
|
|
|
// Add the new files to the checksum_list
|
|
for (const auto& new_file : edit.GetNewFiles()) {
|
|
checksum_list->InsertOneFileChecksum(
|
|
new_file.second.fd.GetNumber(), new_file.second.file_checksum,
|
|
new_file.second.file_checksum_func_name);
|
|
}
|
|
}
|
|
assert(!s.ok() ||
|
|
manifest_file_size == std::numeric_limits<uint64_t>::max() ||
|
|
reader.LastRecordEnd() == manifest_file_size);
|
|
return s;
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|