1d226018af
Summary:
1. In IOTracing, add filename with each IOTrace record. Filename is stored in file object (Tracing Wrappers).
2. Change the logic of figuring out which additional information (file_size,
length, offset etc) needs to be store with each operation
which is different for different operations.
When new information will be added in future (depends on operation),
this change would make the future additions simple.
Logic: In IOTraceRecord, io_op_data is added and its
bitwise positions represent which additional information need
to added in the record from enum IOTraceOp. Values in IOTraceOp represent bitwise positions.
So if length and offset needs to be stored (IOTraceOp::kIOLen
is 1 and IOTraceOp::kIOOffset is 2), position 1 and 2 (from rightmost bit) will be set
and io_op_data will contain 110.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7885
Test Plan: Updated io_tracer_test and verified the trace file manually.
Reviewed By: anand1976
Differential Revision: D25982353
Pulled By: akankshamahajan15
fbshipit-source-id: ebfc5539cc0e231d7794a6b42b73f5403e360b22
65 lines
2.3 KiB
C++
65 lines
2.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#pragma once
|
|
#include <atomic>
|
|
#include <string>
|
|
|
|
#include "env/file_system_tracer.h"
|
|
#include "port/port.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/file_system.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// SequentialFileReader is a wrapper on top of Env::SequentialFile. It handles
|
|
// Buffered (i.e when page cache is enabled) and Direct (with O_DIRECT / page
|
|
// cache disabled) reads appropriately, and also updates the IO stats.
|
|
class SequentialFileReader {
|
|
private:
|
|
std::string file_name_;
|
|
FSSequentialFilePtr file_;
|
|
std::atomic<size_t> offset_{0}; // read offset
|
|
|
|
public:
|
|
explicit SequentialFileReader(
|
|
std::unique_ptr<FSSequentialFile>&& _file, const std::string& _file_name,
|
|
const std::shared_ptr<IOTracer>& io_tracer = nullptr)
|
|
: file_name_(_file_name),
|
|
file_(std::move(_file), io_tracer, _file_name) {}
|
|
|
|
explicit SequentialFileReader(
|
|
std::unique_ptr<FSSequentialFile>&& _file, const std::string& _file_name,
|
|
size_t _readahead_size,
|
|
const std::shared_ptr<IOTracer>& io_tracer = nullptr)
|
|
: file_name_(_file_name),
|
|
file_(NewReadaheadSequentialFile(std::move(_file), _readahead_size),
|
|
io_tracer, _file_name) {}
|
|
|
|
SequentialFileReader(const SequentialFileReader&) = delete;
|
|
SequentialFileReader& operator=(const SequentialFileReader&) = delete;
|
|
|
|
Status Read(size_t n, Slice* result, char* scratch);
|
|
|
|
Status Skip(uint64_t n);
|
|
|
|
FSSequentialFile* file() { return file_.get(); }
|
|
|
|
std::string file_name() { return file_name_; }
|
|
|
|
bool use_direct_io() const { return file_->use_direct_io(); }
|
|
|
|
private:
|
|
// NewReadaheadSequentialFile provides a wrapper over SequentialFile to
|
|
// always prefetch additional data with every read.
|
|
static std::unique_ptr<FSSequentialFile> NewReadaheadSequentialFile(
|
|
std::unique_ptr<FSSequentialFile>&& file, size_t readahead_size);
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|