andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
208556ee13
rocksdb/monitoring
History
Maysam Yabandeh 208556ee13 WritePrepared: fix Get without snapshot (#5664) 
Summary:
if read_options.snapshot is not set, ::Get will take the last sequence number after taking a super-version and uses that as the sequence number. Theoretically max_eviceted_seq_ could advance this sequence number. This could lead ::IsInSnapshot that will be invoked by the ReadCallback to notice the absence of the snapshot. In this case, the ReadCallback should have passed a non-value to snap_released so that it could be set by the ::IsInSnapshot. The patch does that, and adds a unit test to verify it.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5664

Differential Revision: D16614033

Pulled By: maysamyabandeh

fbshipit-source-id: 06fb3fd4aacd75806ed1a1acec7961f5d02486f2
2019-08-05 13:41:21 -07:00
..
file_read_sample.h Change RocksDB License 2017-07-15 16:11:23 -07:00
histogram_test.cc Move test related files under util/ to test_util/ (#5377) 2019-05-30 11:25:51 -07:00
histogram_windowing.cc Support pragma once in all header files and cleanup some warnings (#4339) 2018-09-05 18:13:31 -07:00
histogram_windowing.h fix HistogramWindowingImpl copy-{assignment,constructor} 2017-09-01 11:11:56 -07:00
histogram.cc simplify include directive involving inttypes (#5402) 2019-06-06 13:56:07 -07:00
histogram.h Scale histogram bucket size by constant factor 2017-08-21 17:10:40 -07:00
in_memory_stats_history.cc Persistent Stats: persist stats history to disk (#5046) 2019-06-17 15:21:50 -07:00
in_memory_stats_history.h Persistent Stats: persist stats history to disk (#5046) 2019-06-17 15:21:50 -07:00
instrumented_mutex.cc Move test related files under util/ to test_util/ (#5377) 2019-05-30 11:25:51 -07:00
instrumented_mutex.h Change RocksDB License 2017-07-15 16:11:23 -07:00
iostats_context_imp.h Fix compilation errors for 32bits/LITE/ios build. (#5220) 2019-04-22 16:02:16 -07:00
iostats_context_test.cc Move test related files under util/ to test_util/ (#5377) 2019-05-30 11:25:51 -07:00
iostats_context.cc Directly refernce perf_context internally. 2017-09-15 17:15:10 -07:00
perf_context_imp.h Introduce a CPU time counter in perf_context (#4741) 2018-12-20 12:03:44 -08:00
perf_context.cc Introduce CPU timers for iterator seek and next (#5076) 2019-03-26 16:32:13 -07:00
perf_level_imp.h Change RocksDB License 2017-07-15 16:11:23 -07:00
perf_level.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
perf_step_timer.h Introduce a CPU time counter in perf_context (#4741) 2018-12-20 12:03:44 -08:00
persistent_stats_history.cc Persistent Stats: persist stats history to disk (#5046) 2019-06-17 15:21:50 -07:00
persistent_stats_history.h Persistent Stats: persist stats history to disk (#5046) 2019-06-17 15:21:50 -07:00
statistics_test.cc Move test related files under util/ to test_util/ (#5377) 2019-05-30 11:25:51 -07:00
statistics.cc WritePrepared: fix Get without snapshot (#5664) 2019-08-05 13:41:21 -07:00
statistics.h Still implement StatisticsImpl::measureTime() (#5181) 2019-04-12 11:00:35 -07:00
stats_history_test.cc Exclude StatsHistoryTest.ForceManualFlushStatsCF test from lite mode (#5529) 2019-07-01 16:37:08 -07:00
thread_status_impl.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_updater_debug.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_updater.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_updater.h Use RAII instead of pointers in cf_info_map 2017-09-28 14:26:47 -07:00
thread_status_util_debug.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
thread_status_util.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_util.h Change RocksDB License 2017-07-15 16:11:23 -07:00