andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/db
History
Sagar Vemuri 20dc5e74f2 Optimize range-delete aggregator call in merge helper. 
Summary:
In the condition:
```
if (range_del_agg != nullptr &&
    range_del_agg->ShouldDelete(
        iter->key(),
        RangeDelAggregator::RangePositioningMode::kForwardTraversal) &&
    filter != CompactionFilter::Decision::kRemoveAndSkipUntil) {
...
}
```
it could be possible that all the work done in `range_del_agg->ShouldDelete` is wasted due to not having the right `filter` value later on.
Instead, check `filter` value before even calling `range_del_agg->ShouldDelete`, which is a much more involved function.
Closes https://github.com/facebook/rocksdb/pull/2690

Differential Revision: D5568931

Pulled By: sagar0

fbshipit-source-id: 17512d52360425c7ae9de7675383f5d7bc3dad58
2017-08-05 00:15:35 -07:00
..
builder.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
c_test.c
Added db paths to c
2017-07-24 11:58:02 -07:00
c.cc
Added db paths to c
2017-07-24 11:58:02 -07:00
column_family_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
column_family.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
column_family.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
compact_files_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
compacted_db_impl.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
compacted_db_impl.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
compaction_iteration_stats.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
compaction_iterator_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
compaction_iterator.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
compaction_iterator.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
compaction_job_stats_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
compaction_job_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
compaction_job.cc
Fix compaction div by zero logging
2017-07-24 11:58:02 -07:00
compaction_job.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
compaction_picker_test.cc
Fix FIFO compaction picker test
2017-07-26 12:12:26 -07:00
compaction_picker_universal.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
compaction_picker_universal.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
compaction_picker.cc
Fix caching of compaction picker's next index
2017-07-21 20:57:15 -07:00
compaction_picker.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
compaction.cc
Fix universal compaction bug
2017-07-31 14:27:45 -07:00
compaction.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
comparator_db_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
convenience.cc
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
corruption_test.cc
CodeMod: Prefer ADD_FAILURE() over EXPECT_TRUE(false), et cetera
2017-07-16 21:26:02 -07:00
cuckoo_table_db_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_basic_test.cc
Build fewer tests in Travis platform_dependent tests
2017-07-27 17:29:01 -07:00
db_block_cache_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_bloom_filter_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_compaction_filter_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_compaction_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_dynamic_level_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_encryption_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_filesnapshot.cc
Remove some left-over BSD headers
2017-07-18 11:56:57 -07:00
db_flush_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_impl_compaction_flush.cc
Introduce bottom-pri thread pool for large universal compactions
2017-08-03 15:43:29 -07:00
db_impl_debug.cc
Introduce bottom-pri thread pool for large universal compactions
2017-08-03 15:43:29 -07:00
db_impl_experimental.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_impl_files.cc
move TableCache::EraseHandle outside of db mutex
2017-07-27 12:14:41 -07:00
db_impl_open.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_impl_readonly.cc
Add Iterator::Refresh()
2017-07-24 10:54:37 -07:00
db_impl_readonly.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_impl_write.cc
Remove the orphan assert on !need_log_sync
2017-07-25 18:41:52 -07:00
db_impl.cc
Introduce bottom-pri thread pool for large universal compactions
2017-08-03 15:43:29 -07:00
db_impl.h
Introduce bottom-pri thread pool for large universal compactions
2017-08-03 15:43:29 -07:00
db_info_dumper.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_info_dumper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_inplace_update_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_io_failure_test.cc
Fix LITE unit tests
2017-07-26 21:11:47 -07:00
db_iter_test.cc
Add Iterator::Refresh()
2017-07-24 10:54:37 -07:00
db_iter.cc
Add Iterator::Refresh()
2017-07-24 10:54:37 -07:00
db_iter.h
Add Iterator::Refresh()
2017-07-24 10:54:37 -07:00
db_iterator_test.cc
Add Iterator::Refresh()
2017-07-24 10:54:37 -07:00
db_log_iter_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_memtable_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_merge_operator_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_options_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_properties_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_range_del_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_sst_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_statistics_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_table_properties_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_tailing_iter_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_test2.cc
Fix LITE unit tests
2017-07-26 21:11:47 -07:00
db_test_util.cc
Fix LITE unit tests
2017-07-26 21:11:47 -07:00
db_test_util.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
db_test.cc
Fix FIFO Compaction with TTL tests
2017-07-28 14:42:59 -07:00
db_universal_compaction_test.cc
Introduce bottom-pri thread pool for large universal compactions
2017-08-03 15:43:29 -07:00
db_wal_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_write_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
dbformat_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
dbformat.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
dbformat.h
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
deletefile_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
event_helpers.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
event_helpers.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
experimental.cc
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
external_sst_file_basic_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
external_sst_file_ingestion_job.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
external_sst_file_ingestion_job.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
external_sst_file_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
fault_injection_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
file_indexer_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
file_indexer.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
file_indexer.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
filename_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
flush_job_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
flush_job.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
flush_job.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
flush_scheduler.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
flush_scheduler.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
forward_iterator_bench.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
forward_iterator.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
forward_iterator.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
internal_stats.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
internal_stats.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
job_context.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
listener_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
log_format.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_reader.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_reader.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_writer.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_writer.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
malloc_stats.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
malloc_stats.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
managed_iterator.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
managed_iterator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
manual_compaction_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
memtable_list_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
memtable_list.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
memtable_list.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
memtable.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
memtable.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
merge_context.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
merge_helper_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
merge_helper.cc
Optimize range-delete aggregator call in merge helper.
2017-08-05 00:15:35 -07:00
merge_helper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
merge_operator.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
merge_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
options_file_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
perf_context_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
pinned_iterators_manager.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_db_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
prefix_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
range_del_aggregator_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
range_del_aggregator.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
range_del_aggregator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
repair_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
repair.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
snapshot_impl.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
snapshot_impl.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
table_cache.cc
fix db get/write stats
2017-07-31 12:12:03 -07:00
table_cache.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
table_properties_collector_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
table_properties_collector.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
table_properties_collector.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
transaction_log_impl.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
transaction_log_impl.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
version_builder_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
version_builder.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
version_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
version_edit_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
version_edit.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
version_edit.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
version_set_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
version_set.cc
Introduce bottom-pri thread pool for large universal compactions
2017-08-03 15:43:29 -07:00
version_set.h
Introduce bottom-pri thread pool for large universal compactions
2017-08-03 15:43:29 -07:00
wal_manager_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
wal_manager.cc
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
wal_manager.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
write_batch_base.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
write_batch_internal.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
write_batch_test.cc
Gcc 7 ParsedInternalKey replace memset with clear function.
2017-07-24 11:31:15 -07:00
write_batch.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
write_callback_test.cc
Fix flaky write_callback_test
2017-07-25 16:42:11 -07:00
write_callback.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
write_controller_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
write_controller.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
write_controller.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
write_thread.cc
Fix the overflow bug in AwaitState
2017-08-03 10:43:28 -07:00
write_thread.h
Change RocksDB License
2017-07-15 16:11:23 -07:00