bda8d93ba9
Summary: It's always annoying to find a header does not include its own dependencies and only works when included after other includes. This change adds `make check-headers` which validates that each header can be included at the top of a file. Some headers are excluded e.g. because of platform or external dependencies. rocksdb_namespace.h had to be re-worked slightly to enable checking for failure to include it. (ROCKSDB_NAMESPACE is a valid namespace name.) Fixes mostly involve adding and cleaning up #includes, but for FileTraceWriter, a constructor was out-of-lined to make a forward declaration sufficient. This check is not currently run with `make check` but is added to CircleCI build-linux-unity since that one is already relatively fast. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8893 Test Plan: existing tests and resolving issues detected by new check Reviewed By: mrambacher Differential Revision: D30823300 Pulled By: pdillinger fbshipit-source-id: 9fff223944994c83c105e2e6496d24845dc8e572
55 lines
1.8 KiB
C++
55 lines
1.8 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "db/dbformat.h"
|
|
#include "rocksdb/types.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class ReadCallback {
|
|
public:
|
|
explicit ReadCallback(SequenceNumber last_visible_seq)
|
|
: max_visible_seq_(last_visible_seq) {}
|
|
ReadCallback(SequenceNumber last_visible_seq, SequenceNumber min_uncommitted)
|
|
: max_visible_seq_(last_visible_seq), min_uncommitted_(min_uncommitted) {}
|
|
|
|
virtual ~ReadCallback() {}
|
|
|
|
// Will be called to see if the seq number visible; if not it moves on to
|
|
// the next seq number.
|
|
virtual bool IsVisibleFullCheck(SequenceNumber seq) = 0;
|
|
|
|
inline bool IsVisible(SequenceNumber seq) {
|
|
assert(min_uncommitted_ > 0);
|
|
assert(min_uncommitted_ >= kMinUnCommittedSeq);
|
|
if (seq < min_uncommitted_) { // handles seq == 0 as well
|
|
assert(seq <= max_visible_seq_);
|
|
return true;
|
|
} else if (max_visible_seq_ < seq) {
|
|
assert(seq != 0);
|
|
return false;
|
|
} else {
|
|
assert(seq != 0); // already handled in the first if-then clause
|
|
return IsVisibleFullCheck(seq);
|
|
}
|
|
}
|
|
|
|
inline SequenceNumber max_visible_seq() { return max_visible_seq_; }
|
|
|
|
// Refresh to a more recent visible seq
|
|
virtual void Refresh(SequenceNumber seq) { max_visible_seq_ = seq; }
|
|
|
|
protected:
|
|
// The max visible seq, it is usually the snapshot but could be larger if
|
|
// transaction has its own writes written to db.
|
|
SequenceNumber max_visible_seq_ = kMaxSequenceNumber;
|
|
// Any seq less than min_uncommitted_ is committed.
|
|
const SequenceNumber min_uncommitted_ = kMinUnCommittedSeq;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|