rocksdb/table/plain
Peter Dillinger 68626249c3 Refactor/consolidate legacy Bloom implementation details (#5784)
Summary:
Refactoring to consolidate implementation details of legacy
Bloom filters. This helps to organize and document some related,
obscure code.

Also added make/cpp var TEST_CACHE_LINE_SIZE so that it's easy to
compile and run unit tests for non-native cache line size. (Fixed a
related test failure in db_properties_test.)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5784

Test Plan:
make check, including Recently added Bloom schema unit tests
(in ./plain_table_db_test && ./bloom_test), and including with
TEST_CACHE_LINE_SIZE=128U and TEST_CACHE_LINE_SIZE=256U. Tested the
schema tests with temporary fault injection into new implementations.

Some performance testing with modified unit tests suggest a small to moderate
improvement in speed.

Differential Revision: D17381384

Pulled By: pdillinger

fbshipit-source-id: ee42586da996798910fc45ac0b6289147f16d8df
2019-09-16 16:17:09 -07:00
..
plain_table_bloom.cc Refactor/consolidate legacy Bloom implementation details (#5784) 2019-09-16 16:17:09 -07:00
plain_table_bloom.h Refactor/consolidate legacy Bloom implementation details (#5784) 2019-09-16 16:17:09 -07:00
plain_table_builder.cc Divide file_reader_writer.h and .cc (#5803) 2019-09-16 10:33:51 -07:00
plain_table_builder.h Use delete to disable automatic generated methods. (#5009) 2019-09-11 18:09:00 -07:00
plain_table_factory.cc Organizing rocksdb/table directory by format 2019-05-30 14:51:11 -07:00
plain_table_factory.h Organizing rocksdb/table directory by format 2019-05-30 14:51:11 -07:00
plain_table_index.cc simplify include directive involving inttypes (#5402) 2019-06-06 13:56:07 -07:00
plain_table_index.h Move some memory related files from util/ to memory/ (#5382) 2019-05-30 17:44:09 -07:00
plain_table_key_coding.cc Divide file_reader_writer.h and .cc (#5803) 2019-09-16 10:33:51 -07:00
plain_table_key_coding.h Move some memory related files from util/ to memory/ (#5382) 2019-05-30 17:44:09 -07:00
plain_table_reader.cc Refactor/consolidate legacy Bloom implementation details (#5784) 2019-09-16 16:17:09 -07:00
plain_table_reader.h Divide file_reader_writer.h and .cc (#5803) 2019-09-16 10:33:51 -07:00