andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
sdong 692f6a3138 Implement NextAndGetResult() in memtable and level iterator (#7179) 
Summary:
NextAndGetResult() is not implemented in memtable and is very simply implemented in level iterator. The result is that for a normal leveled iterator, performance regression will be observed for calling PrepareValue() for most iterator Next(). Mitigate the problem by implementing the function for both iterators. In level iterator, the implementation cannot be perfect as when calling file iterator's SeekToFirst() we don't have information about whether the value is prepared. Fortunately, the first key should not cause a big portion of the CPu.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7179

Test Plan: Run normal crash test for a while.

Reviewed By: anand1976

Differential Revision: D22783840

fbshipit-source-id: c19f45cdf21b756190adef97a3b66ccde3936e05
2020-07-29 09:45:21 -07:00
..
adaptive
Extend Get/MultiGet deadline support to table open (#6982)
2020-06-29 14:53:17 -07:00
block_based
minimize BlockIter comparator scope (#7149)
2020-07-20 14:07:04 -07:00
cuckoo
Extend Get/MultiGet deadline support to table open (#6982)
2020-06-29 14:53:17 -07:00
plain
Fixed Factory construct just for calling .Name() (#7080)
2020-07-08 11:54:00 -07:00
block_fetcher_test.cc
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
block_fetcher.cc
Skip unnecessary allocation for mmap reads under 5000 bytes (#7043)
2020-06-30 15:40:40 -07:00
block_fetcher.h
Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)
2020-04-24 15:32:56 -07:00
cleanable_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
format.cc
Extend Get/MultiGet deadline support to table open (#6982)
2020-06-29 14:53:17 -07:00
format.h
Extend Get/MultiGet deadline support to table open (#6982)
2020-06-29 14:53:17 -07:00
get_context.cc
Add timestamp to delete (#6253)
2020-05-28 10:40:03 -07:00
get_context.h
Stats for redundant insertions into block cache (#6681)
2020-04-27 13:20:27 -07:00
internal_iterator.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
iter_heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
iterator_wrapper.h
Implement NextAndGetResult() in memtable and level iterator (#7179)
2020-07-29 09:45:21 -07:00
iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
merger_test.cc
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
merging_iterator.cc
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
merging_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
meta_blocks.cc
Separate internal and user key comparators in BlockIter (#6944)
2020-07-07 17:26:16 -07:00
meta_blocks.h
Extend Get/MultiGet deadline support to table open (#6982)
2020-06-29 14:53:17 -07:00
mock_table.cc
Add hash of key/value checks when paranoid_file_checks=true (#7134)
2020-07-22 11:04:40 -07:00
mock_table.h
Add hash of key/value checks when paranoid_file_checks=true (#7134)
2020-07-22 11:04:40 -07:00
multiget_context.h
Allow MultiGet users to limit cumulative value size (#6826)
2020-05-27 13:07:14 -07:00
persistent_cache_helper.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_helper.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_options.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
scoped_arena_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_dumper.cc
Fix GetFileDbIdentities (#7104)
2020-07-09 08:37:59 -07:00
sst_file_dumper.h
Fix GetFileDbIdentities (#7104)
2020-07-09 08:37:59 -07:00
sst_file_reader_test.cc
Allow table/sst_file_reader_test.cc to use custom Env (#6536)
2020-03-17 11:02:13 -07:00
sst_file_reader.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer_collectors.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer.cc
Store DB identity and DB session ID in SST files (#6983)
2020-06-17 10:57:40 -07:00
table_builder.h
Store DB identity and DB session ID in SST files (#6983)
2020-06-17 10:57:40 -07:00
table_properties_internal.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_properties.cc
Store DB identity and DB session ID in SST files (#6983)
2020-06-17 10:57:40 -07:00
table_reader_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader_caller.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader.h
For ApproximateSizes, pro-rate table metadata size over data blocks (#6784)
2020-06-02 12:30:23 -07:00
table_test.cc
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
two_level_iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
two_level_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00