rocksdb

History

Mike Kolupaev e45673dece Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 ) Summary: Context: Index type `kBinarySearchWithFirstKey` added the ability for sst file iterator to sometimes report a key from index without reading the corresponding data block. This is useful when sst blocks are cut at some meaningful boundaries (e.g. one block per key prefix), and many seeks land between blocks (e.g. for each prefix, the ranges of keys in different sst files are nearly disjoint, so a typical seek needs to read a data block from only one file even if all files have the prefix). But this added a new error condition, which rocksdb code was really not equipped to deal with: `InternalIterator::value()` may fail with an IO error or Status::Incomplete, but it's just a method returning a Slice, with no way to report error instead. Before this PR, this type of error wasn't handled at all (an empty slice was returned), and kBinarySearchWithFirstKey implementation was considered a prototype. Now that we (LogDevice) have experimented with kBinarySearchWithFirstKey for a while and confirmed that it's really useful, this PR is adding the missing error handling. It's a pretty inconvenient situation implementation-wise. The error needs to be reported from InternalIterator when trying to access value. But there are ~700 call sites of `InternalIterator::value()`, most of which either can't hit the error condition (because the iterator is reading from memtable or from index or something) or wouldn't benefit from the deferred loading of the value (e.g. compaction iterator that reads all values anyway). Adding error handling to all these call sites would needlessly bloat the code. So instead I made the deferred value loading optional: only the call sites that may use deferred loading have to call the new method `PrepareValue()` before calling `value()`. The feature is enabled with a new bool argument `allow_unprepared_value` to a bunch of methods that create iterators (it wouldn't make sense to put it in ReadOptions because it's completely internal to iterators, with virtually no user-visible effect). Lmk if you have better ideas. Note that the deferred value loading only happens for internal iterators. The user-visible iterator (DBIter) always prepares the value before returning from Seek/Next/etc. We could go further and add an API to defer that value loading too, but that's most likely not useful for LogDevice, so it doesn't seem worth the complexity for now. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6621 Test Plan: make -j5 check . Will also deploy to some logdevice test clusters and look at stats. Reviewed By: siying Differential Revision: D20786930 Pulled By: al13n321 fbshipit-source-id: 6da77d918bad3780522e918f17f4d5513d3e99ee		2020-04-15 17:40:44 -07:00
..
blob	Add blob files to VersionStorageInfo/VersionBuilder (#6597 )	2020-03-26 18:51:53 -07:00
compaction	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
db_impl	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
arena_wrapped_db_iter.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
arena_wrapped_db_iter.h	Iterator with timestamp (#6255 )	2020-03-06 16:24:27 -08:00
builder.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
builder.h	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
c_test.c	Return NotSupported from WriteBatchWithIndex::DeleteRange (#5393 )	2020-02-18 11:18:25 -08:00
c.cc	added new functions to c-api (#5630 )	2020-04-07 14:45:39 -07:00
column_family_test.cc	fix some spelling typos (#6464 )	2020-02-28 14:14:03 -08:00
column_family.cc	Attempt to recover from db with missing table files (#6334 )	2020-03-20 19:30:48 -07:00
column_family.h	Attempt to recover from db with missing table files (#6334 )	2020-03-20 19:30:48 -07:00
compact_files_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
compacted_db_impl.cc	return timestamp from get (#6409 )	2020-03-02 16:01:00 -08:00
compacted_db_impl.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
comparator_db_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
convenience.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
corruption_test.cc	Simplify migration to FileSystem API (#6552 )	2020-03-23 21:54:21 -07:00
cuckoo_table_db_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_basic_test.cc	Add pipelined & parallel compression optimization (#6262 )	2020-04-01 16:40:18 -07:00
db_block_cache_test.cc	Revert the recent cache deleter change (#6620 )	2020-03-31 16:11:06 -07:00
db_bloom_filter_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_compaction_filter_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_compaction_test.cc	Compaction with timestamp: input boundaries (#6645 )	2020-04-10 16:05:49 -07:00
db_dynamic_level_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_encryption_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_filesnapshot.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_flush_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_info_dumper.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_info_dumper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_inplace_update_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_io_failure_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_iter_stress_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_iter_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_iter.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
db_iter.h	make iterator return versions between timestamp bounds (#6544 )	2020-04-10 09:51:58 -07:00
db_iterator_test.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
db_log_iter_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_logical_block_size_cache_test.cc	Get block size only in direct IO mode (#6522 )	2020-03-20 15:26:10 -07:00
db_memtable_test.cc	return timestamp from get (#6409 )	2020-03-02 16:01:00 -08:00
db_merge_operand_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_merge_operator_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_options_test.cc	Move the OptionTypeMap code closer to home (#6198 )	2020-04-03 10:52:38 -07:00
db_properties_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_range_del_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_sst_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_statistics_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_table_properties_test.cc	Report kFilesMarkedForCompaction for delete triggered compactions (#6680 )	2020-04-10 15:30:38 -07:00
db_tailing_iter_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_test2.cc	Add pipelined & parallel compression optimization (#6262 )	2020-04-01 16:40:18 -07:00
db_test_util.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_test_util.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_test.cc	Report kFilesMarkedForCompaction for delete triggered compactions (#6680 )	2020-04-10 15:30:38 -07:00
db_universal_compaction_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
db_wal_test.cc	Fix db_wal_test::TruncateLastLogAfterRecoverWithoutFlush failure (#6437 )	2020-03-05 17:18:16 -08:00
db_with_timestamp_basic_test.cc	Fix release build (#6690 )	2020-04-11 22:04:04 -07:00
db_with_timestamp_compaction_test.cc	Compaction with timestamp: input boundaries (#6645 )	2020-04-10 16:05:49 -07:00
db_write_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
dbformat_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
dbformat.cc	Iterator with timestamp (#6255 )	2020-03-06 16:24:27 -08:00
dbformat.h	Iterator with timestamp (#6255 )	2020-03-06 16:24:27 -08:00
deletefile_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
error_handler_fs_test.cc	Revamp cache_bench to resemble a real workload (#6629 )	2020-04-03 10:26:49 -07:00
error_handler.cc	Be able to decrease background thread's CPU priority when creating database backup (#6602 )	2020-03-28 19:07:25 -07:00
error_handler.h	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
event_helpers.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
event_helpers.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
experimental.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
external_sst_file_basic_test.cc	Fix range deletion tombstone ingestion with global seqno (#6429 )	2020-02-25 15:31:48 -08:00
external_sst_file_ingestion_job.cc	Replace Directory with FSDirectory in DB (#6468 )	2020-03-02 16:16:26 -08:00
external_sst_file_ingestion_job.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
external_sst_file_test.cc	Fix wrong key being read on ingested file with global seqno and delta encoding (#6669 )	2020-04-08 21:22:15 -07:00
fault_injection_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
file_indexer_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
file_indexer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
file_indexer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
filename_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
flush_job_test.cc	Fix initializer syntax for old Xcode compiler (#6662 )	2020-04-07 16:00:26 -07:00
flush_job.cc	Make options.bottommost_compression, compression_opts and bottommost_compression_opts dynamically changeable. (#6615 )	2020-03-31 12:11:42 -07:00
flush_job.h	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
flush_scheduler.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
flush_scheduler.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
forward_iterator_bench.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
forward_iterator.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
forward_iterator.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
import_column_family_job.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
import_column_family_job.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
import_column_family_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
internal_stats.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
internal_stats.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
job_context.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
listener_test.cc	Move BlobDB related files under db/ to db/blob/ (#6519 )	2020-03-12 11:00:56 -07:00
log_format.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
log_reader.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
log_reader.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
log_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
log_writer.cc	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
log_writer.h	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
logs_with_prep_tracker.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
logs_with_prep_tracker.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
lookup_key.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
malloc_stats.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
malloc_stats.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
manual_compaction_test.cc	Skip high levels with no key falling in the range in CompactRange (#6482 )	2020-03-04 20:15:25 -08:00
memtable_list_test.cc	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
memtable_list.cc	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
memtable_list.h	Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487 )	2020-03-27 16:04:43 -07:00
memtable.cc	multiget support for timestamps (#6483 )	2020-03-24 11:24:09 -07:00
memtable.h	return timestamp from get (#6409 )	2020-03-02 16:01:00 -08:00
merge_context.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
merge_helper_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
merge_helper.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
merge_helper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
merge_operator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
merge_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
obsolete_files_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
options_file_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
perf_context_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
pinned_iterators_manager.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
plain_table_db_test.cc	Add ppc64le builds to Travis (#6144 )	2020-03-11 12:33:45 -07:00
pre_release_callback.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
prefix_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
range_del_aggregator_bench.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
range_del_aggregator_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
range_del_aggregator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
range_del_aggregator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
range_tombstone_fragmenter_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
range_tombstone_fragmenter.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
range_tombstone_fragmenter.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
read_callback.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
repair_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
repair.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
snapshot_checker.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
snapshot_impl.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
snapshot_impl.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
table_cache.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
table_cache.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
table_properties_collector_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
table_properties_collector.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
table_properties_collector.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
transaction_log_impl.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
transaction_log_impl.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
trim_history_scheduler.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
trim_history_scheduler.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
version_builder_test.cc	Add blob files to VersionStorageInfo/VersionBuilder (#6597 )	2020-03-26 18:51:53 -07:00
version_builder.cc	Add blob files to VersionStorageInfo/VersionBuilder (#6597 )	2020-03-26 18:51:53 -07:00
version_builder.h	Attempt to recover from db with missing table files (#6334 )	2020-03-20 19:30:48 -07:00
version_edit_handler.cc	Attempt to recover from db with missing table files (#6334 )	2020-03-20 19:30:48 -07:00
version_edit_handler.h	Attempt to recover from db with missing table files (#6334 )	2020-03-20 19:30:48 -07:00
version_edit_test.cc	Revert "Added the safe-to-ignore tag to version_edit (#6530 )" (#6569 )	2020-03-23 10:27:47 -07:00
version_edit.cc	Revert "Added the safe-to-ignore tag to version_edit (#6530 )" (#6569 )	2020-03-23 10:27:47 -07:00
version_edit.h	Revert "Added the safe-to-ignore tag to version_edit (#6530 )" (#6569 )	2020-03-23 10:27:47 -07:00
version_set_test.cc	Compaction with timestamp: input boundaries (#6645 )	2020-04-10 16:05:49 -07:00
version_set.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
version_set.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	2020-04-15 17:40:44 -07:00
wal_manager_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
wal_manager.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
wal_manager.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_batch_base.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_batch_internal.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_batch_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_batch.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_callback_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_callback.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_controller_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_controller.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_controller.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
write_thread.cc	fix some spelling typos (#6464 )	2020-02-28 14:14:03 -08:00
write_thread.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00